test: add unit tests for 4 services (achievements-notifications, achievements, analytics, batch-size-guard) - #1361
Merged
RUKAYAT-CODER merged 2 commits intoAug 27, 2026
Conversation
…alytics, and batch-size-guard services (rinafcode#1253 rinafcode#1254 rinafcode#1255 rinafcode#1256)
|
@NteinPrecious Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused unit test suites for four previously untested services, satisfying the acceptance criteria of issues #1253–#1256.
#1253 — achievements-notifications.service
Added
src/achievements/achievements-notifications.service.spec.ts.Covers:
sendAchievementUnlockedNotification— marks notification sent; swallows repository errors gracefullysendBatchNotifications— returns correct count; returns 0 on empty result or repository failureresendFailedNotifications— retries up to 100 records; returns 0 on failureCloses #1253
#1254 — achievements.service
Added
src/achievements/achievements.service.spec.ts(co-located with source, as required).Covers:
createAchievement— saves entity and invalidates cachegetAchievementById— returns dto; throwsNotFoundExceptionwhen missingupdateAchievement— updates and invalidates cache; throwsNotFoundExceptionwhen missingdeactivateAchievement— setsisActive: falsehasAchievement— returnstrue/falsebased on unlock recordgetUserAchievementCount— delegates to repositoryunlockAchievement— creates unlock event; skips duplicate; throwsNotFoundExceptioninitializeProgress— reuses existing progress; creates when absent; throwsNotFoundExceptiongetUserProgressForAchievement— returns dto; throwsNotFoundExceptionwhen absentCloses #1254
#1255 — analytics.service
Added
src/analytics/analytics.service.spec.ts.Covers:
trackEvent— validates, batches, increments counter; re-throwsBadRequestException; wraps unknown errorsrecordEventand all assessment helpers — no-throw when counter is nullgetEvents— returns empty set; applies all optional filtersgetAnalyticsSummary— returns zeroed summary; maps raw query results into response shapeCloses #1255
#1256 — batch-size-guard.service
Added
src/analytics/services/batch-size-guard.service.spec.ts.Covers:
canAdd— returnstruebelow max; returnsfalseat and above max; increments dropped count only on rejectiongetDroppedCount— starts at zero; accumulates correctlyresetDroppedCount— resets to zero; idempotent on zeroCloses #1256