Open
Conversation
If the connect board has more than 5 columns moves past the 4th column couldn't be played. Eg. if the connect board has 6 columns play_move(5) should be legal since there is a 5th column.
The previous code worked because of a fluke that connect.board_size_y+1 equaled connect.board_size_x. The height of a connect board has no bearing on the possible moves, only the width does.
fotto
added a commit
to fotto/Grokking-Artificial-Intelligence-Algorithms
that referenced
this pull request
Apr 12, 2026
generation of possible moves used wrong argument compare with implementation of alpha-beta-pruning was already part of PR rishal-hurbans#9 but not taken over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor fixes. The first fixes boundary checks when playing a move. The second fixes move generation in the minmax algorithm.