chore(iceberg): bump iceberg chain to fb290e4c/a9ce53cc#25366
Open
chore(iceberg): bump iceberg chain to fb290e4c/a9ce53cc#25366
Conversation
Li0k
commented
Apr 15, 2026
| .map_err(|_| { | ||
| ErrorCode::InvalidInputSyntax(format!( | ||
| "{} must be a positive integer: {}", | ||
| COMPACTION_WRITE_PARQUET_MAX_ROW_GROUP_ROWS, write_parquet_max_row_group_rows |
Contributor
Author
There was a problem hiding this comment.
@chenzl25 I plan to deprecate this parameter. Should we intercept it and throw an error when creating a table?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Supersedes #25333, which GitHub would not reopen after the original head branch was renamed/recreated.
What changed?
iceberg-rust(iceberg,iceberg-catalog-glue,iceberg-catalog-rest) tofb290e4c9473b1fb4b582e9ac88a8fe08d2265ef.iceberg-compaction-coreinrisingwave_storagetoa9ce53cc3a8401148b604897c1b586655a35a23e.compaction.write_parquet_max_row_group_bytes; keepcompaction.write_parquet_max_row_group_rowsas compatibility-only and ignore it with a warning.Cargo.lockafter the rev bump to avoid unrelated dependency regressions.Validation
cargo check -p risingwave_batch -p risingwave_connector -p risingwave_storage -p risingwave_frontend --features risingwave_frontend/datafusioncargo check -p risingwave_storage --lockedcargo check -p risingwave_connector --lockedcargo check -p risingwave_frontend --features datafusion --locked