Skip to content

chore(iceberg): bump iceberg chain to fb290e4c/a9ce53cc#25366

Open
Li0k wants to merge 5 commits intomainfrom
li0k/bump-iceberg-compaction-bd254371
Open

chore(iceberg): bump iceberg chain to fb290e4c/a9ce53cc#25366
Li0k wants to merge 5 commits intomainfrom
li0k/bump-iceberg-compaction-bd254371

Conversation

@Li0k
Copy link
Copy Markdown
Contributor

@Li0k Li0k commented Apr 15, 2026

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

Supersedes #25333, which GitHub would not reopen after the original head branch was renamed/recreated.

What changed?

  • Bump iceberg-rust (iceberg, iceberg-catalog-glue, iceberg-catalog-rest) to fb290e4c9473b1fb4b582e9ac88a8fe08d2265ef.
  • Bump iceberg-compaction-core in risingwave_storage to a9ce53cc3a8401148b604897c1b586655a35a23e.
  • Align the Iceberg path with Arrow/Parquet 58, including the batch parquet path and frontend DataFusion 53 path.
  • Replace the deprecated row-count parquet row-group setting with compaction.write_parquet_max_row_group_bytes; keep compaction.write_parquet_max_row_group_rows as compatibility-only and ignore it with a warning.
  • Tighten Cargo.lock after the rev bump to avoid unrelated dependency regressions.

Validation

  • cargo check -p risingwave_batch -p risingwave_connector -p risingwave_storage -p risingwave_frontend --features risingwave_frontend/datafusion
  • cargo check -p risingwave_storage --locked
  • cargo check -p risingwave_connector --locked
  • cargo check -p risingwave_frontend --features datafusion --locked

@Li0k Li0k requested a review from a team as a code owner April 15, 2026 11:37
@Li0k Li0k requested review from wenym1 and removed request for a team April 15, 2026 11:37
.map_err(|_| {
ErrorCode::InvalidInputSyntax(format!(
"{} must be a positive integer: {}",
COMPACTION_WRITE_PARQUET_MAX_ROW_GROUP_ROWS, write_parquet_max_row_group_rows
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenzl25 I plan to deprecate this parameter. Should we intercept it and throw an error when creating a table?

Copy link
Copy Markdown
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Li0k Li0k changed the title chore(iceberg): bump iceberg chain to fb290e4c/bd254371 chore(iceberg): bump iceberg chain to fb290e4c/a9ce53cc Apr 16, 2026
@Li0k Li0k enabled auto-merge April 16, 2026 05:33
@Li0k Li0k added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
@Li0k Li0k added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants