fix(gsheets-logger): park undelivered rows across a spreadsheet rotation - #97
Merged
Merged
Conversation
…the new sheet onConfigChange drains the buffer before swapping the client, so rows land in the spreadsheet they were captured for. But flush() swallows its own failure, so a drain that could not reach Sheets leaves every row in place — and the next flush sends message content captured under one spreadsheet and credential to whichever target the operator just rotated to. Rows still queued after the drain are moved to their own storage key and reported once. They are kept, not discarded, and they never cross the boundary the rotation just drew.
`reply` quote-replies to the sender, which the description said was "visible to them". In a group that is every member: the transcript of a voice note read out to the whole chat. The option still defaults to off and its behaviour is unchanged — the config description and the README table now state the consequence where an operator reads it, before switching it on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onConfigChange drains the buffer before swapping the client so rows land in the spreadsheet they were captured for. But
flush()swallows its own failure, so a drain that could not reach Sheets leaves every row in place — and the next flush sends message content captured under one spreadsheet and credential to whichever target the operator just rotated to.Rows still queued after the drain are now moved to their own storage key and reported once. They are kept rather than discarded, and they never cross the boundary the rotation just drew.
Also clarifies
voice-transcription'schatDelivery: reply. The description said the transcript is "visible to them"; in a group that is every member, which is worth knowing before switching it on. Behaviour is unchanged and it still defaults tooff.Verification