Skip to content

Fix a number of clang-tidy detected defects#22416

Open
jblomer wants to merge 37 commits into
root-project:masterfrom
jblomer:tidy
Open

Fix a number of clang-tidy detected defects#22416
jblomer wants to merge 37 commits into
root-project:masterfrom
jblomer:tidy

Conversation

@jblomer
Copy link
Copy Markdown
Contributor

@jblomer jblomer commented May 28, 2026 •
edited
Loading

A test run of clang-tidy on the RNTuple code with the following checks

Checks: 'bugprone-*,-bugprone-assignment-in-if-condition,-bugprone-branch-clone,-bugprone-derived-method-shadowing-base-method,-bugprone-easily-swappable-parameters,-bugprone-implicit-widening-of-multiplication-result,-bugprone-incorrect-enable-if,-bugprone-macro-parentheses,-bugprone-multi-level-implicit-pointer-conversion,-bugprone-narrowing-conversions,-bugprone-not-null-terminated-result,-bugprone-random-generator-seed,-bugprone-reserved-identifier,-bugprone-signed-char-misuse,-bugprone-std-namespace-modification,-bugprone-switch-missing-default-case,-bugprone-throwing-static-initialization,-bugprone-too-small-loop-variable,-bugprone-unchecked-optional-access,-bugprone-unhandled-self-assignment,-bugprone-unused-return-value,-bugprone-virtual-near-miss,cppcoreguidelines-virtual-class-destructor,misc-*,-misc-non-private-member-variables-in-classes,-misc-include-cleaner,-misc-misplaced-const,-misc-multiple-inheritance,-misc-no-recursion,misc-non-copyable-objects,-misc-non-private-member-variables-in-classes,-misc-predictable-rand,-misc-unconventional-assign-operator,-misc-use-anonymous-namespace,performance-*,-performance-enum-size,-performance-inefficient-string-concatenation,-performance-no-int-to-ptr,-performance-noexcept-swap,readability-duplicate-include,readability-delete-null-pointer,readability-misleading-indentation,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-reference-to-constructed-temporary'

@jblomer jblomer self-assigned this May 28, 2026
@jblomer jblomer requested review from dpiparo and pcanal as code owners May 28, 2026 12:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026 •
edited
Loading

Test Results

    20 files      20 suites   3d 8h 35m 53s ⏱️
 3 864 tests  3 566 ✅   0 💤 298 ❌
69 656 runs  68 804 ✅ 259 💤 593 ❌

For more details on these failures, see this check.

Results for commit 0aaf399.

♻️ This comment has been updated with latest results.

jblomer added 25 commits June 2, 2026 13:45
@jblomer
[ntuple] fix argument comment
e65b5ff
@jblomer
[io] fix casting through void
e6c96eb
@jblomer
[RVec] avoid unnecessary capacity check in internal set_size
3aaf0d1
@jblomer
[ntuple] avoid throwing impossible exception
2b12921
@jblomer
[ntuple] don't throw in RNTupleModel::~RUpdater()
54cdde1
@jblomer
[ntuple] safer use of RException
a816682
@jblomer
[core] make RException nothrow copy constructible
97682c7
@jblomer
[ntuple] fix throwing exception in RNTupleDescriptor
81f3304
@jblomer
[ntuple] remove wrong forward declaration of RFieldVisitor
9c70bae
@jblomer
[core] fix definition of kMaxULong
6135634
@jblomer
[ntuple] merger: minor improvement in optional assignment
76674f5
@jblomer
[meta] remove unused TClassEdit::GetUniquePtrType()
3a03db1 
With commit c5ee8b5 (enable unique_ptr
support for nested STL collections), the method
TClassEdit::GetUniquePtrType() became obsolete.
@jblomer
[ntuple] minor readability improvement
b0cd742
@jblomer
[ntuple] minor improvement in RPageSourceFile::CreateFromAnchor()
907d881
@jblomer
[ntuple] remove unused variable in RFieldBase::Create()
ed040e0
@jblomer
[ntuple] fix use-after-move in RNTupleDescriptorBuilder::AddColumn()
7b2802a
@jblomer
[NFC][ntuple] suppress clang-tidy false positive
2c710b8
@jblomer
[ntuple] fix widening method visibility change
41b2b3a
@jblomer
[ntuple] remove unusued usings
b295c6f
@jblomer
[ntuple] move RAuxiliaryProcessorField to anonymous namespace
6cef18b
@jblomer
[ntuple] move RKeyBlob to anonymous namespace
fa17ecb
@jblomer
[ntuple] private linkage of stream operator in the merger
57d1eb5
@jblomer
[ntuple] replace std::endl by \n
7351ad8
@jblomer
[ntuple] minor performance improvement in RPageSourceFile::LoadCluste…
c888811 
…rs()
@jblomer
[core] pass RError::RLocation by const ref
d946abb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jblomer jblomer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jblomer