[ml] Fix out-of-bounds read in filtered cluster split#22440
Merged
guitargeek merged 1 commit intoMay 31, 2026
Conversation
In RClusterLoader::LoadTrainingClusterInto the boundary entry was read from rdfEntries unconditionally before checking valCount, so when one side of the split is empty the access was past end-of-vector. This was silent in non-hardened builds but trips libstdc++ assertions (e.g. with libcxxhardeningfast), aborting test09_filtered_last_chunk. Compute the boundary only when the corresponding rdfEntries index is in-bounds, falling back to the cluster endpoint otherwise.
Test Results 22 files 22 suites 3d 10h 14m 28s ⏱️ Results for commit df5c093. |
guitargeek
added
the
pr:emergency🚨
1 task
1 task
jblomer
approved these changes
May 31, 2026
Contributor
Author
|
\backport to 6.40 |
Contributor
Author
|
/backport to 6.40 |
|
Preparing to backport PR #22440 to branch 6.40 requested by guitargeek |
|
Something went wrong when assigning the PR or setting labels @guitargeek please see the logs |
|
This PR has been backported to branch 6.40: #22441 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RClusterLoader::LoadTrainingClusterInto the boundary entry was read from rdfEntries unconditionally before checking valCount, so when one side of the split is empty the access was past end-of-vector. This was silent in non-hardened builds but trips libstdc++ assertions (e.g. with libcxxhardeningfast), aborting test09_filtered_last_chunk.
Compute the boundary only when the corresponding rdfEntries index is in-bounds, falling back to the cluster endpoint otherwise.