refactor(toolbar): extract font-size into configurable CSS variable - #1352
Merged
Conversation
Move the hardcoded 0.9rem font-size into a pseudo-private custom property (--_toolbar-font-size) that reads from a global variable (--bslib-toolbar-font-size), following the existing pattern for other toolbar properties. This allows the toolbar font size to be customized while maintaining a single source of truth within each toolbar instance.
gadenbuie
marked this pull request as ready for review
August 21, 2026 16:06
cpsievert
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the hardcoded
font-size: 0.9reminto a pseudo-private custom property (--_toolbar-font-size) that reads from a global variable (--bslib-toolbar-font-size), following the existing pattern for other toolbar properties. This allows the toolbar font size to be customized while maintaining a single source of truth within each toolbar instance.