Repository navigation
Use simple patterns for locating version number - #1081
Merged
Merged
Conversation
Makes it less likely that the wrong version number is updated. * hypb-release.el (hypb-release-version-file-list): Rename variable as it is now a list of lists. (hypb-release--replace-version): Replaces the version number based on a given pattern (hypb-release-update-version): Use hypb-release-update-version. (hypb-release-update-hyperbole-version-header): Add pattern. * test/MANIFEST: Add hypb-release-tests.el. * test/hypb-release-tests.el: New test file for hypb-release.el. (hypb-release-tests--replace-version): (hypb-release-tests--update-version): Test cases. * man/hyperbole.texi: Use EDITION and VERSION variables.
matsl
force-pushed
the
pr_smarter_version_update_using_patterns
branch
from
October 16, 2026 20:05
59c5c25 to
256d224
Compare
rswgnu
requested changes
Oct 17, 2026
rswgnu
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes it less likely that the wrong version number is updated.
hypb-release.el (hypb-release-version-file-list): Rename variable as
it is now a list of lists.
(hypb-release--replace-version): Replaces the version number based on
a given pattern
(hypb-release-update-version): Use hypb-release-update-version.
(hypb-release-update-hyperbole-version-header): Add pattern.
test/MANIFEST: Add hypb-release-tests.el.
test/hypb-release-tests.el: New test file for hypb-release.el.
(hypb-release-tests--replace-version):
(hypb-release-tests--update-version): Test cases.
man/hyperbole.texi: Use EDITION and VERSION variables.
Why
With documents having static version numbers we need to be more
precise when looking for the number to updated. This uses a pattern of
leading or surrounding text to find the version number.
Also removes the use of plain text version numbers in hyperbole.texi
in favor of using the variables that is already there and used in
other places.
HY-NEWS is also removed from the list of files to update since that
should not be affected by a version bump. The version numbers in that
file are static.