quieten compiler warnings - #890
Open
ourairquality wants to merge 1 commit into
Open
Conversation
ourairquality
force-pushed
the
comp-warns-quieten
branch
3 times, most recently
from
June 22, 2026 08:38
b3791c2 to
6241d84
Compare
ourairquality
force-pushed
the
comp-warns-quieten
branch
4 times, most recently
from
August 5, 2026 11:48
94e07e4 to
a689b24
Compare
Owner
|
AI review flagged a couple of possible issues. Can you check them?
|
Misc type coercion issues. Many related to the change of the obs_t SNR from an int to a float that generate warnings with MSC. rtksvrostat: change the SNR output argument from int to double, and rework the callers. The obs_t SNR is now a float rather than an integer. str2time: The guard for the width was wrong. Change the start and width arguments to be size_t to help avoid compiler warnings. stream: deal with differences between unix-style and windows for sockets and devices.
ourairquality
force-pushed
the
comp-warns-quieten
branch
from
August 28, 2026 05:15
a689b24 to
d760441
Compare
Author
|
Good points, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with Visual Studio, MSC, generated a lot of warnings that I had not seen with BCC. Significant issues were split out and this is the remainder of the changes to quieten them. Most are harmless expected coercion losses, but there was some odd code reworked.
Explicit type coercion.