fix: get correct plural when n is in string#315
Closed
zhuangya wants to merge 1 commit into
Closed
Conversation
zhuangya
force-pushed
the
fix-plural
branch
from
4c39472 to
1c04d3e
Compare
Author
|
🤔 anyone? |
|
+1 |
Owner
|
As mentioned in #275, I'd rather not merge this. Make sure your data is good before it arrives at angular-gettext. JS might not be strongly-typed, but that doesn't mean that types don't matter. Strings aren't numbers, the only person who knows if a conversion can be done safely is you. |
Author
so you're telling me, every single time i use angular-gettext with input(type=range), i need something like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #313 fix #305