Remove XPath namespace axis handling part which is not working at all#323
Open
tompng wants to merge 1 commit into
Open
Remove XPath namespace axis handling part which is not working at all#323tompng wants to merge 1 commit into
tompng wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds graceful handling for the XPath namespace axis in REXML by preventing exceptions and introducing a regression test.
Changes:
- Add a test to ensure
namespace::*does not raise (regression forNoMethodError). - Replace attempted namespace-axis evaluation with a warning and an empty result set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/xpath/test_base.rb | Adds a regression test around namespace::* behavior. |
| lib/rexml/xpath_parser.rb | Stops attempting to evaluate namespace axis; emits warning and returns empty nodeset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+226
to
+228
| warn 'Namespace axis is not supported in REXML::XPathParser', uplevel: 1 | ||
| # TODO: We need to create NamespaceNode class to support this feature | ||
| nodeset = [] |
| end | ||
| nodesets | ||
| end | ||
| warn 'Namespace axis is not supported in REXML::XPathParser', uplevel: 1 |
Comment on lines
+251
to
+257
| def test_axe_namespace_no_error | ||
| $VERBOSE, verbose = nil, $VERBOSE | ||
| # Although namespace axis is not implemented yet, it should not raise NoMethodError | ||
| XPath.match(@@doc, "a/d/c/namespace::*") | ||
| ensure | ||
| $VERBOSE = verbose | ||
| end |
Namespace axis should return a nodeset of Namespace Node, but Namespace Node class has not even been defined yet.
b66d135 to
c1a8b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespace axis should return a nodeset of Namespace Node, but Namespace Node class has not even been defined yet.
So namespace axis is completely unimplemented.
Right now, this incomplete code is just getting in the way of refactoring.
Other options: