Repository navigation
Delete dead sweet-alert-confirm.js (#7306) - #7335
Merged
compwron merged 1 commit intoNov 3, 2026
Merged
Conversation
KoushikSagarr
requested review from
FireLemons,
elasticspoon and
schoork
as code owners
November 3, 2026 07:07
compwron
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves [#7306]
What changed, and why?
app/javascript/sweet-alert-confirm.jsconfirmation handler.app/javascript/application.js.data-confirm-swalattributes.sweetalert2dependency because other JavaScript modules still import and useSwaldirectly.This is another small, independently reviewable contribution toward removing obsolete JavaScript code from CASA.
How is this tested? (please write rspec and jest tests!) 💖💪
npm run build && npm run build:csspassed.spec/system/volunteers/edit_spec.rb— 36 examples, 0 failures.git diff --checkpassed with no whitespace errors.sweetalert2dependency was left unchanged.Screenshots please :)
Not applicable — the existing confirmation behavior is preserved; this PR only removes the obsolete confirmation handler.
Feelings gif (optional)
Goodbye, obsolete confirmation handler. The dialogs still work, and the codebase gets a little cleaner! 💪