Repository navigation
ci: run a smoke-test subset in the docker workflow - #7352
Open
aniketpatidar wants to merge 2 commits into
Open
aniketpatidar wants to merge 2 commits into
aniketpatidar wants to merge 2 commits into
Conversation
The docker and rspec workflows both ran the full RSpec suite, doubling PR check runtime and flake exposure. Keep the docker job as a smoke test of the built image with the health request spec and the login system spec; the full suite still runs in the rspec workflow.
aniketpatidar
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
November 7, 2026 05:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the full RSpec suite in the
dockerworkflow with two smoke specs:spec/requests/health_spec.rbspec/system/sessions/login_spec.rbThe
rspecworkflow continues to run the full suite, so coverage is unchanged.Why
Both workflows ran the entire suite, which doubled PR check runtime and flake exposure. This follows the proposal in #6507 (and the direction noted in #7173): keep the docker job as a smoke test that proves the built image boots, connects to the database, and can log a user in.
Verification
Ran the two specs inside the docker compose stack (same steps as the workflow):
Closes #6507.