Eagerly fetch typeck results when linting

[Jarcho]

View all comments

The first commit avoids running the lint visitor if all lints were filtered out. In every other case the typeck results are accessed on every body making the delayed load pointless overhead.

[rustbot]

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

[rustbot]

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 73 candidates
• Random selection from 20 candidates

[Jarcho]

Turns out that was load bearing for rustdoc. That's now been worked around and documented properly.

[fmease]

@bors try parent=4fc35880d9636c5a2679d18b034038123b09b294 @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 0b2216b (0b2216bdab7b8a5d0d896736af184122a08d45de)
Base parent: 4fc3588 (4fc35880d9636c5a2679d18b034038123b09b294)

[rust-timer]

Error occured while categorizing benchmark run:

could not find start commit for bound Commit("4fc35880d9636c5a2679d18b034038123b09b294")

[fmease]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 1444460 (14444609e8e293e12bab60ce6cd32f4b81c9adcf)
Base parent: 9639eef (9639eefc07db282b25e9c83cdfebb10688ed5114)

[Kivooeo]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 09bb986 (09bb986007d65d026cf7742c8b6861bf7022b46b)
Base parent: f28ac76 (f28ac764c36004fa6a6e098d15b4016a838c13c6)

[rust-timer]

Finished benchmarking commit (09bb986): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 510.446s -> 504.716s (-1.12%)
Artifact size: 353.05 MiB -> 352.95 MiB (-0.03%)

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Kivooeo]

@rustbot reroll

[adwinwhite]

() is kinda confusing. Could you use a more descriptive name and add some comments to this trait definition?
Or just use const parameter like RequiresTypeck: bool on LateContextAndPass?

View changes since the review

[Jarcho]

A const param would likely be better.

[adwinwhite]

It seems that this is the only place we use enclosing_body. Can this condition ever be false?
And do we need to do this save and restore stuff for typeck_result at all if we eagerly fetch typeck result for every body? 🤔

View changes since the review

[Jarcho]

Const bodies also flow through here without hitting check_fn.

[Jarcho]

Restoring has to happen anytime a nested body occurs. e.g. nested function, closure, const block...