Skip to content

Rollup of 8 pull requests - #160758

Closed
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-N4JA4fH
Closed

Rollup of 8 pull requests#160758
JonathanBrouwer wants to merge 19 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-N4JA4fH

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

zakrad and others added 19 commits August 6, 2026 11:19
…ouwer

Move attributes out of rustc_hir

Previous graph:

<img width="397" height="503" alt="image" src="https://github.com/user-attachments/assets/f1c101b1-eb2f-4032-a8e7-6b4f6aef39d5" />

Graph with this pr:

<img width="505" height="524" alt="image" src="https://github.com/user-attachments/assets/489be58e-41c5-4c08-a25a-9dc04ebe00e2" />

So while it doesn't really look like much (might be nicer for pipeling or if you're editing rustc_hir), it unblocks followup work to split up this part of the crate graph further, like:
- moving `SanitizerSet` to a (new?) crate below `rustc_target` so that `rustc_target` and `rustc_attr_ir` no longer depend on each other and can compile in parallel
- `rustc_session` will only depend on `rustc_hir` for `rustc_hir::definitions` in its `cstore` module, there may be something there but I haven't looked in depth.

There's some work left wrt cleaning up imports everywhere, but that's for followups.

r? @JonathanBrouwer
Add regression test for unsized non-last struct field with overlapping impls

Closes rust-lang#83097 adds a regresion test locking that  E0277 & E0119 are both emitted
miri: implement more restrictive trivial-ABI checks

This implements the rules from rust-lang#157973 in Miri. We unfortunately have to reject some code that we thought was okay. Let's land this in Miri ahead of anything official also to see if there's any major breakage from that.

r? @oli-obk
Add regression test for higher ranked fn pointer impl not general enough

Closes rust-lang#57936 adds a regression test for higher ranked fn-pointer impl is now correctly rejected
…-onboard, r=jieyouxu

triagebot: add ubiratan to infra-ci

Pretty much self-explained :)

 r? @marcoieni
…ez,JonathanBrouwer

rustc_errors: remove unused code

r? @GuillaumeGomez
…nBrouwer

Add regression test for incremental borrowck ICE with generic const exprs

Adds an incremental regression test for rust-lang#125564 for generic-const exprs snippet, now reports errors cleanly

Closes rust-lang#125564
…anBrouwer

rustc_lint: remove unused rustc_attrs feature
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Aug 8, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple-,x86_64-mingw-1,i686-msvc-

@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 62e9b79 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026
@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit 62e9b79 with merge 8643c4f

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/31259507296

rust-bors Bot pushed a commit that referenced this pull request Aug 8, 2026
Rollup of 8 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-*
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors try cancel

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2026
@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved due to being closed.

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 8, 2026
@rust-bors

rust-bors Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants