Remove #[rustc_reservation_impl] - #160871
Merged
rust-bors[bot] merged 5 commits intoAug 25, 2026
Merged
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
remove_rustc_reservation_impl
branch
from
August 10, 2026 18:59
dc47214 to
5bb1e02
Compare
Contributor
|
The use case I described for I think it's fine to remove this specific hack and later replace it with something else if it happens to use the same name. |
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
remove_rustc_reservation_impl
branch
from
August 17, 2026 10:37
5bb1e02 to
15f38ce
Compare
2 tasks
oli-obk
approved these changes
Aug 19, 2026
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
remove_rustc_reservation_impl
branch
from
August 25, 2026 12:31
15f38ce to
7c1e726
Compare
WaffleLapkin
marked this pull request as ready for review
August 25, 2026 12:43
Collaborator
|
This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410 Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_ir |
rustbot
added
S-waiting-on-review
Member
|
I also took a look at this before realizing Oli already had, oops |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
Member
|
@bors r=oli-obk,JonathanBrouwer |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
…uwer Rollup of 13 pull requests Successful merges: - #158874 (hir_ty_lowering: fix anon const type recovery) - #161443 (add internal DSL for testing binders) - #161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - #161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - #161729 (miri subtree update) - #161745 (make trivial ABI check resilient against new repr) - #160871 (Remove `#[rustc_reservation_impl]`) - #161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - #161522 (test `f16::mul_add` not double-rounding the result) - #161631 (Add two comments relating to new-solver performance) - #161724 (Add codegen test for static table search loop unrolling) - #161740 (do not compress debuginfo for Cygwin) - #161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 25, 2026
Rollup merge of #160871 - WaffleLapkin:remove_rustc_reservation_impl, r=oli-obk,JonathanBrouwer Remove `#[rustc_reservation_impl]` Based on #160705. There was only ever one reservation impl and it got (/is being) removed in #160705. I don't think there is a reason to keep the machinery, given how specific and tricky the semantics of it are (see #64631). Closes #64631. cc @clarfonthey since you seem to have found another use for the attribute (#64631 (comment)) (I haven't looked into it, so not sure if it might be worth keeping the attribute for that use case). r? types
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#158874 (hir_ty_lowering: fix anon const type recovery) - rust-lang/rust#161443 (add internal DSL for testing binders) - rust-lang/rust#161617 (Add custom allocators to `(try_)map` on `Box`, `Rc`, `Arc`) - rust-lang/rust#161726 (Fix debugger visualizer tuple child ordering w/ PDB debug info) - rust-lang/rust#161729 (miri subtree update) - rust-lang/rust#161745 (make trivial ABI check resilient against new repr) - rust-lang/rust#160871 (Remove `#[rustc_reservation_impl]`) - rust-lang/rust#161180 (Detect missing binding available: add a MaybeIncorrect suggestion) - rust-lang/rust#161522 (test `f16::mul_add` not double-rounding the result) - rust-lang/rust#161631 (Add two comments relating to new-solver performance) - rust-lang/rust#161724 (Add codegen test for static table search loop unrolling) - rust-lang/rust#161740 (do not compress debuginfo for Cygwin) - rust-lang/rust#161750 (vector ABI check: reword so it makes more sense for non-obviously-vector types)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #160705.
There was only ever one reservation impl and it got (/is being) removed in #160705. I don't think there is a reason to keep the machinery, given how specific and tricky the semantics of it are (see #64631).
Closes #64631.
cc @clarfonthey since you seem to have found another use for the attribute (#64631 (comment)) (I haven't looked into it, so not sure if it might be worth keeping the attribute for that use case).
r? types