Skip to content

Add test for parallel compiler reproducible build - #161353

Open
aerooneqq wants to merge 1 commit into
rust-lang:mainfrom
aerooneqq:static-muts-repr-build-test
Open

Add test for parallel compiler reproducible build#161353
aerooneqq wants to merge 1 commit into
rust-lang:mainfrom
aerooneqq:static-muts-repr-build-test

Conversation

@aerooneqq

@aerooneqq aerooneqq commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Adds a test for reproducible binaries when using parallel compiler.

Confirmed with bisection and manual testing that #144722 fixed #140413, added test fails before commit (075ce31) from #144722.

********************************************************************************
Regression in nightly-2025-08-14
********************************************************************************

fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd311791bfd9dca886abdfbab07ec54d8b4
fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55b7cfd0a12e7097197b6242872473ffaa7
looking for regression commit between 2025-08-13 and 2025-08-14
fetching (via remote github) commits from max(8e62bfd311791bfd9dca886abdfbab07ec54d8b4, 2025-08-11) to 3672a55b7cfd0a12e7097197b6242872473ffaa7
ending github query because we found starting sha: 8e62bfd311791bfd9dca886abdfbab07ec54d8b4
get_commits_between returning commits, len: 7
  commit[0] 2025-08-12: Auto merge of #144678 - jdonszelmann:no-mangle-extern, r=bjorn3
  commit[1] 2025-08-12: Auto merge of #145295 - Kobzol:unify-stages, r=jieyouxu
  commit[2] 2025-08-13: Auto merge of #145093 - nikic:dead-on-return, r=nnethercote
  commit[3] 2025-08-13: Auto merge of #145334 - Kobzol:rollup-fs5a133, r=Kobzol
  commit[4] 2025-08-13: Auto merge of #144722 - ywxt:parallel-reproducibile, r=SparrowLii
  commit[5] 2025-08-13: Auto merge of #145298 - nikic:llvm21-rc3, r=cuviper
  commit[6] 2025-08-13: Auto merge of #145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez

Fixes #140413.

r? @petrochenkov

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2026
@rust-log-analyzer

This comment has been minimized.

@aerooneqq
aerooneqq force-pushed the static-muts-repr-build-test branch from 8a116c4 to 2016bf9 Compare August 19, 2026 12:34
@aerooneqq
aerooneqq marked this pull request as ready for review August 19, 2026 12:45
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2026
Comment thread tests/run-make/parallel-reproducible-build/rmake.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2026
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors squash msg="Add test for parallel compiler reproducible build"

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🔨 2 commits were squashed into 2311296.

@rust-bors
rust-bors Bot force-pushed the static-muts-repr-build-test branch from c60c047 to 2311296 Compare August 28, 2026 16:13
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2311296 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 28, 2026
…est, r=petrochenkov

Add test for parallel compiler reproducible build

Adds a test for reproducible binaries when using parallel compiler.

Confirmed with bisection and manual testing that rust-lang#144722 fixed rust-lang#140413, added test fails before commit (075ce31) from rust-lang#144722.
```rust
********************************************************************************
Regression in nightly-2025-08-14
********************************************************************************

fetching https://static.rust-lang.org/dist/2025-08-13/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2025-08-13: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 357.18 KB/s converted 2025-08-13 to 8e62bfd
fetching https://static.rust-lang.org/dist/2025-08-14/channel-rust-nightly-git-commit-hash.txt
nightly manifest 2025-08-14: 40 B / 40 B [============================================================================================================================================================================] 100.00 % 123.86 KB/s converted 2025-08-14 to 3672a55
looking for regression commit between 2025-08-13 and 2025-08-14
fetching (via remote github) commits from max(8e62bfd, 2025-08-11) to 3672a55
ending github query because we found starting sha: 8e62bfd
get_commits_between returning commits, len: 7
  commit[0] 2025-08-12: Auto merge of rust-lang#144678 - jdonszelmann:no-mangle-extern, r=bjorn3
  commit[1] 2025-08-12: Auto merge of rust-lang#145295 - Kobzol:unify-stages, r=jieyouxu
  commit[2] 2025-08-13: Auto merge of rust-lang#145093 - nikic:dead-on-return, r=nnethercote
  commit[3] 2025-08-13: Auto merge of rust-lang#145334 - Kobzol:rollup-fs5a133, r=Kobzol
  commit[4] 2025-08-13: Auto merge of rust-lang#144722 - ywxt:parallel-reproducibile, r=SparrowLii
  commit[5] 2025-08-13: Auto merge of rust-lang#145298 - nikic:llvm21-rc3, r=cuviper
  commit[6] 2025-08-13: Auto merge of rust-lang#145366 - GuillaumeGomez:rollup-v0a6v3u, r=GuillaumeGomez
```

Fixes rust-lang#140413.

r? @petrochenkov
rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
…uwer

Rollup of 15 pull requests

Successful merges:

 - #160170 (Refactored docs for `std::fs::set_permissions_nofollow` + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag)
 - #160594 (attach global target features to module-level assembly)
 - #161858 (fix ICE in generic_const_parameter_types with inherents)
 - #161353 (Add test for parallel compiler reproducible build)
 - #161377 ([bootstrap] Don't reverse the order of dylib search path entries)
 - #161804 (Document PartialOrd behavior for Option<T> where T: PartialOrd)
 - #161865 (loongarch: support passing `u128`/`i128` to inline assembly)
 - #161877 (Do not load macro metadata for local definitions in rustdoc)
 - #161880 (fix rustc_lint_defs doctest issues)
 - #161883 (better deal with internal features being injected into doctests)
 - #161887 (std: uefi: fix File::seek returning the EOF sentinel)
 - #161897 (Reject contract attributes without arguments)
 - #161909 (Report the configured Polonius default in -Z help)
 - #161910 (Add rustdoc-html regression test for generated macro)
 - #161914 (Retroactively add relnotes for `bool::{ok_or,ok_or_else}` (1.98.0))
@JonathanBrouwer

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #161942 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel rustc: static mut refs not reproducible

5 participants