[beta] bump stage0, plus backports

[cuviper]

• Bump stage0 to stable 1.98.0
• fix buggy MaybeDangling<&T> validation logic fix buggy MaybeDangling<&T> validation logic #161125
• resolving cyclic glob vis-max resolving cyclic glob vis-max #161024

r? me

[rustbot]

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

[cuviper]

@bors r+ rollup=never

[rust-bors]

📌 Commit 043ef18 has been approved by cuviper

It is now in the queue for this repository.

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:start] format::InternalRustfmt {  }
[TIMING:end] format::InternalRustfmt {  } -- 0.000

thread 'main' (1407) panicked at src/build_helper/src/drop_bomb/mod.rs:47:13:
command constructed at `src/bootstrap/src/core/build_steps/tool.rs:1607:23` was dropped without being executed: `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/intrinsic-test`
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/88d9e12ae178fab0fb5cc050a94da85685d449ea/library/std/src/panicking.rs:679:5
   1: core::panicking::panic_fmt
             at /rustc/88d9e12ae178fab0fb5cc050a94da85685d449ea/library/core/src/panicking.rs:80:14
   2: <build_helper::drop_bomb::DropBomb as core::ops::drop::Drop>::drop
   3: core::ptr::drop_glue::<build_helper::drop_bomb::DropBomb>
             at /rustc/88d9e12ae178fab0fb5cc050a94da85685d449ea/library/core/src/ptr/mod.rs:823:1
   4: core::ptr::drop_glue::<bootstrap::utils::exec::BootstrapCommand>
             at /rustc/88d9e12ae178fab0fb5cc050a94da85685d449ea/library/core/src/ptr/mod.rs:823:1
   5: <bootstrap::core::build_steps::test::IntrinsicTest as bootstrap::core::builder::CommandLineStep>::run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:1196:5
   6: <bootstrap::core::build_steps::test::IntrinsicTest as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:130:9
   7: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::test::IntrinsicTest>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1618:36
   8: <bootstrap::core::build_steps::test::IntrinsicTest as bootstrap::core::builder::CommandLineStep>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/test.rs:1074:17
   9: <bootstrap::core::builder::CommandLineStepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:463:13
  10: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:53:22
  11: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1144:9
  12: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1102:14
  13: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:801:25
  14: bootstrap::cli_main::main
             at /checkout/src/bootstrap/src/cli_main.rs:161:11
  15: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:7:5

[rust-bors]

💔 Test for b18e17a failed: CI. Failed job:

• auto - aarch64-gnu (web logs, enhanced plaintext logs)

[cuviper]

WARNING: intrinsic-test skipped because rustfmt is required but not available on this channel
[TIMING:start] format::InternalRustfmt {  }
[TIMING:end] format::InternalRustfmt {  } -- 0.000

thread 'main' (1407) panicked at src/build_helper/src/drop_bomb/mod.rs:47:13:
command constructed at `src/bootstrap/src/core/build_steps/tool.rs:1607:23` was dropped without being executed: `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/intrinsic-test`

That WARNING has an early return per #159265 (@xonx4l, @Kobzol), but it looks like it should defuse the command too. Even better, it could go way up near the target check, so it's before any filesystem modification.