Skip to content

implement VaArgSafe for f128 - #161424

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:va-arg-f128
Sep 19, 2026
Merged

implement VaArgSafe for f128#161424
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:va-arg-f128

Conversation

@folkertdev

@folkertdev folkertdev commented Aug 20, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

On some platforms, especially when long double is IEEE f128 on the platform.

@folkertdev folkertdev added the F-c_variadic `#![feature(c_variadic)]` label Aug 20, 2026
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 20, 2026
@folkertdev

folkertdev commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
@bors
Auto merge of #161424 - folkertdev:va-arg-f128, r=<try>
c9719b5 
implement `VaArgSafe` for `f128`


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
folkertdev
folkertdev commented Aug 20, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? tgross35

View changes since this review

Comment thread library/core/src/ffi/va_list.rs
Comment thread tests/run-make/c-link-to-rust-va-list-fn/checkrust.rs Outdated
@folkertdev
folkertdev marked this pull request as ready for review August 20, 2026 21:52
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026
@rust-bors

rust-bors Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c9719b5 failed: CI. Failed job:

@folkertdev

folkertdev commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161424 - folkertdev:va-arg-f128, r=<try>
d5f25c2 
implement `VaArgSafe` for `f128`


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
folkertdev
folkertdev commented Aug 21, 2026
View reviewed changes
Comment thread library/core/src/ffi/va_list.rs
@rust-bors

rust-bors Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d5f25c2 (d5f25c2d0c850c37c152ae4a21b215d1c6f7960a)
Base parent: a872286 (a872286d0a1873caec0291ed4304de3170adbe16)

@folkertdev

folkertdev commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2026
tgross35
tgross35 reviewed Aug 25, 2026
View reviewed changes
Comment thread library/core/src/ffi/va_list.rs
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0b42c3c has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161424 - folkertdev:va-arg-f128, r=tgross35
c8af049 
implement `VaArgSafe` for `f128`

On some platforms, especially when `long double` is IEEE f128 on the platform.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 18, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Sep 18, 2026

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162980 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2026
@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#162980), which was unapproved.

View changes since this unapproval

@folkertdev

folkertdev commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026
@bors
Auto merge of #161424 - folkertdev:va-arg-f128, r=<try>
113b1ae 
implement `VaArgSafe` for `f128`


try-job: test-various
@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 113b1ae (113b1aeda69d315bbc9379b926288f61b2f947b3)
Base parent: 420ed2a (420ed2a0c3d7225b1744266fd884d431b4d8cfe0)

@folkertdev

folkertdev commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=tgross35

@rust-bors

rust-bors Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3d281d4 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 19, 2026
@Zalathar
Rollup merge of rust-lang#161424 - folkertdev:va-arg-f128, r=tgross35
167fcb2 
implement `VaArgSafe` for `f128`

On some platforms, especially when `long double` is IEEE f128 on the platform.
@Zalathar Zalathar mentioned this pull request Sep 19, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #162996 - Zalathar:rollup-uUWX3SP, r=Zalathar
1f3278c 
Rollup of 18 pull requests

Successful merges:

 - #162499 (`rustc_codegen_gcc` subtree update)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162981 (rustc-dev-guide subtree update)

Failed merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #162996 - Zalathar:rollup-uUWX3SP, r=tgross35
3d463a0 
Rollup of 18 pull requests

Successful merges:

 - #162499 (`rustc_codegen_gcc` subtree update)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162875 (Add .seek_read_exact(), .seek_write_all() to std::os::windows::fs::FileExt)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162981 (rustc-dev-guide subtree update)

Failed merges:

 - #162177 (Properly implement the gpu-kernel ABI for amdgpu)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 19, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161424 - folkertdev:va-arg-f128, r=tgross35
626be09 
implement `VaArgSafe` for `f128`

On some platforms, especially when `long double` is IEEE f128 on the platform.
This was referenced Sep 19, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Auto merge of #163002 - JonathanBrouwer:rollup-iOYYbuh, r=JonathanBro…
36b04f3 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #163001 (Temporarily disable `test-x86_64-fuchsia`)
 - #162880 (Mini optimization in `rustc_hir_typeck::upvar::restrict_precision_for_drop_types`)
 - #161424 (implement `VaArgSafe` for `f128`)
 - #161777 (Add Natvis visualiser and debuginfo tests for `f128`)
 - #162506 (Avoid suggesting imports of traits declared inside fn bodies)
 - #162591 (Move parse error recovery for expression operators "out of line" & refactor in the area)
 - #162669 ([rustdoc] Correctly handle intra-doc links on inlined same item with different names)
 - #162733 (Add useful APIs to `Unique(Arc|Rc)`)
 - #162913 (Refactor LivenessResults into LivenessComputation, without typeck)
 - #162924 (Remove applying inline attributes at the callsite)
 - #162940 (Use spawned `SBDebugger` instance)
 - #162950 (More AST lowering cleanups)
 - #162964 (Update `browser-ui-test` version to `0.25.2`)
 - #162979 (mark `f128` as reliable on `powerpc64` with `+vsx`)
 - #161743 (Add performance notes for the floating-point round method)
 - #162797 (yeet AliasConstKind::opt_def_id)
 - #162836 (Ping T-libs-ping instead of T-libs-fcp for backports)
 - #162873 (Adjust `bug!`/`span_bug!` emission)
 - #162956 (Add missing `#[repr(C)]` in UI, codegen and assembly tests)
 - #162971 (libtest harness: avoid 'extern crate test' with custom runner)
 - #162981 (rustc-dev-guide subtree update)
 - #162985 (Error on invalid placements for unstable attributes)
@rust-bors
rust-bors Bot merged commit ddab882 into rust-lang:main Sep 19, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 19, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 19, 2026
@bors
Unrolled build for #161424 in rollup 163002
906a3f5 
Rollup merge of #161424 - folkertdev:va-arg-f128, r=tgross35

implement `VaArgSafe` for `f128`

On some platforms, especially when `long double` is IEEE f128 on the platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beetrees beetrees beetrees requested changes
@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs F-c_variadic `#![feature(c_variadic)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

6 participants

@folkertdev @rust-log-analyzer @rustbot @JonathanBrouwer @tgross35 @beetrees