Skip to content

add regression test for #142717 - #162978

Open
imlazyeye wants to merge 1 commit into
rust-lang:mainfrom
imlazyeye:chore/fn-ptr-no-ice-test
Open

imlazyeye wants to merge 1 commit into
rust-lang:mainfrom
imlazyeye:chore/fn-ptr-no-ice-test

Conversation

@imlazyeye

@imlazyeye imlazyeye commented Sep 18, 2026

Copy link
Copy Markdown

Adds regression tests for #142717.

Like the issue says, the ICE is resolved on the new solver, but compiletest forces -Znext-solver=coherence which will make it still occur. That's why the UI test has globally to pin the fixed behavior but the crash test exists for the broken one.

Let me know if both tests are not necessary/if this should indeed close that issue.

r? types

@rustbot

rustbot commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 18, 2026
@rustbot

rustbot commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @spastorino (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • types expanded to 7 candidates
  • Random selection from jackh726, lcnr, oli-obk, spastorino

@rustbot

This comment has been minimized.

@imlazyeye
imlazyeye force-pushed the chore/fn-ptr-no-ice-test branch from 7226e6d to 811e4ae Compare September 18, 2026 16:48
@paradoxicalguy

Copy link
Copy Markdown
Contributor

lgtm. split between the old/new solver tests seems consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants