fix: broken line:column indicator in errors - #6996
Open
eopb wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
eopb
force-pushed
the
push-vkzonostxxvy
branch
2 times, most recently
from
July 29, 2026 14:11
585d843 to
d4f6091
Compare
I noticed that I was seeing error messages from rustfmt that contained paths ending in `:line:line:column`. The example `:3:3:20` can be found in the snapshot tests in this diff. This appears to be related to how `annotate_snippets` automatically appends these indicators when annotations are set. To fix this, I'm only appending `:line` when annotations are not set.
ytmimi
requested changes
Aug 1, 2026
Comment on lines
2
to
8
| source: src/test/mod.rs | ||
| --- | ||
| error[internal]: line formatted, but exceeded maximum width (maximum: 100 (see `max_width` option), found: 109) | ||
| --> tests/warning/source/line_overflow.rs:1:1:101 | ||
| --> tests/warning/source/line_overflow.rs:1:101 | ||
| | | ||
| 1 | fn this_function_name_is_intentionally_long_enough_to_exceed_the_default_one_hundred_character_maximum_width( | ||
| | ^^^^^^^^^ |
Contributor
There was a problem hiding this comment.
Can you help better understand where these annotations are getting added by annotate_snippets like you mention in the PR description. This doesn't seem like a zero width span like you mention in your comment in src/format_report_formatter.rs.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that I was seeing error messages from rustfmt that contained paths ending in
:line:line:column. The example:3:3:20can be found in the snapshot tests in this diff.This appears to be related to how
annotate_snippetsautomatically appends these indicators when annotations are set.To fix this, I'm only appending
:linewhen annotations are not set.