Skip to content

Declare psm MSRV - #149

Open
tisonkun wants to merge 1 commit into
rust-lang:masterfrom
tisonkun:codex/psm-msrv
Open

Declare psm MSRV#149
tisonkun wants to merge 1 commit into
rust-lang:masterfrom
tisonkun:codex/psm-msrv

Conversation

@tisonkun

@tisonkun tisonkun commented Jul 27, 2026

Copy link
Copy Markdown

Declare Rust 1.88 as the minimum supported Rust version for psm, matching ar_archive_writer 0.5.2, and add dedicated MSRV CI coverage.

Addresses #139.

@tisonkun tisonkun mentioned this pull request Jul 27, 2026
@nagisa

nagisa commented Jul 27, 2026

Copy link
Copy Markdown
Member

nack, I don't think downgrading the dep is on the table; we also don't really need to maintain msrv that low at this point. annotating rust-version for psm appropriately seems like the most reasonable thing.

@tisonkun

Copy link
Copy Markdown
Author

CI failure doesn't seem related but downloading failures.

@tisonkun

Copy link
Copy Markdown
Author

@nagisa That's OK. But perhaps we should still define an MSRV for psm? In this case, ar_archive_writer requires 1.88 which we may use. Or use an even-earilier ar_archive_writer to keep lower MSRV.

I personally prefer higher MSRV because old Rust versions are anyway no maintained. Even I'd prefer the Rust team says that old versions are unmaintained so bumping your MSRV is preferred :D

@nagisa

nagisa commented Jul 27, 2026

Copy link
Copy Markdown
Member

Yeah, as I said I would be okay with specifying the factual rust-version for psm. Not that it would help your referenced use-case in stacksafe because crates.io already has releases that don't specify rust-version.

Declare Rust 1.88 as psm's minimum supported Rust version, matching ar_archive_writer 0.5.2, and test it in CI.
@tisonkun tisonkun changed the title Fix psm MSRV compatibility Declare psm MSRV Jul 27, 2026
@tisonkun

Copy link
Copy Markdown
Author

@nagisa OK. I've update the MSRV of psm to 1.88.

For stacksafe case, I think I can update its MSRV to 1.88 as well and at least later we should not face this rust-version incompatible issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants