Skip to content

feat: organize console navigation by product domain - #296

Merged
cxymds merged 2 commits into
mainfrom
cxymds/reorganize-console-navigation
Nov 13, 2026
Merged

cxymds merged 2 commits into
mainfrom
cxymds/reorganize-console-navigation

Conversation

@cxymds

@cxymds cxymds commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Pull Request

Description

Bucket operations are scattered across the global sidebar, requiring users to reselect a bucket when moving between its objects and rules. Organize navigation into Data Management, Identity, Cluster Management, Security and Compliance, Operations, and Administration. Add shared bucket navigation that retains the selected bucket across Objects, Bucket Settings, Bucket Replication, Events, and Lifecycle.

Keep existing routes and permission rules, including a bucket entry that falls back to the first permitted rule page. Preserve existing feature names except the approved Encryption & Keys menu/page title and shorter Decommission submenu. Place S3 Tables last in Data Management, User Groups before Users, and License in Administration. Pool operations remain accessible when the sidebar is collapsed. Update breadcrumbs and all 15 locales, with only the final breadcrumb marked as the current page.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed

Passed locally with Node.js 22 on top of 173bb38:

pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
pnpm test:run  # 988 passed, 0 failed, 0 skipped
git diff --check

The production build also passes in GitHub Actions.

Navigation tests cover the approved ordering, permission filtering and landing routes, selected states, encoded bucket/object paths, rendered breadcrumb accessibility, rendered bucket links, and localization. Browser checks used controlled S3/admin responses to verify desktop and mobile navigation, collapsed pool menus, bucket context, Chinese labels, dark mode, and an account restricted to bucket events. On mobile, the current bucket destination scrolls into view and selecting a sidebar link closes the drawer.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Implements the agreed Console menu organization task; no linked issue.

Screenshots (if applicable)

Running Console with controlled S3/admin responses. The desktop pair uses the same bucket, empty event state, English locale, light theme, and 1280 × 720 viewport. Before is the unmodified 173bb38 baseline; after shows this PR's navigation.

Before After
Before: global bucket operations After: grouped sidebar and bucket navigation
Mobile, dark mode, and the restored License entry Current bucket destination visible on mobile

Dark mode bucket navigation

License under Administration in Chinese

Additional Notes

Browser validation used a local mock backend; this does not establish live storage integration coverage. Existing business actions, URL paths, and permission definitions are unchanged. Screenshot assets are kept on a separate review-assets branch and are not part of the application diff.

Group related cluster, security, identity, and administration tasks while keeping existing routes and permission boundaries. Keep bucket operations in a shared workspace, preserve bucket context in navigation, and apply the approved menu labels and order.
Copilot AI balanced review requested due to automatic review settings November 13, 2026 08:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Non-link breadcrumb ancestors are rendered with aria-current="page", causing assistive technology to announce multiple current pages instead of only the final item.

1 open issue
What changed in this PR

This PR reorganizes Console navigation around six product domains and adds shared bucket navigation so users can move between objects, settings, and rules without reselecting a bucket.

Changes:

  • Groups sidebar destinations, adds collapsed pool menus, and aligns permission-aware landing routes.
  • Integrates bucket navigation into existing pages and updates breadcrumbs.
  • Updates all 15 locales and adds navigation, permission, rendering, and localization tests.
File Description
tests/​lib/​top-nav-breadcrumb-source.test.js Removes the source-based migration label assertion.
tests/​lib/​sidebar-navigation.test.ts Tests ordering, permissions, landing routes, and breadcrumbs.
tests/​lib/​navigation-locales.test.js Checks translated navigation and preserved feature labels.
tests/​lib/​bucket-navigation.test.ts Tests bucket links, permissions, and rendered headers.
lib/​sidebar-navigation.ts Extracts sidebar filtering, grouping, and active-state logic.
lib/​navigation-breadcrumbs.ts Builds bucket-aware and nested navigation breadcrumbs.
lib/​dashboard-route-meta.ts Aligns landing-route order with the grouped navigation.
lib/​bucket-navigation.ts Defines bucket destinations and permission-aware entry routes.
i18n/​locales/​zh-TW.json Adds Traditional Chinese navigation labels.
i18n/​locales/​zh-CN.json Adds Simplified Chinese labels and updates Operations wording.
i18n/​locales/​vi-VN.json Adds Vietnamese navigation labels.
i18n/​locales/​tr-TR.json Adds Turkish navigation labels.
i18n/​locales/​ru-RU.json Adds Russian navigation labels.
i18n/​locales/​pt-BR.json Adds Brazilian Portuguese navigation labels.
i18n/​locales/​ko-KR.json Adds Korean navigation labels.
i18n/​locales/​ja-JP.json Adds Japanese navigation labels.
i18n/​locales/​it-IT.json Adds Italian navigation labels.
i18n/​locales/​id-ID.json Adds Indonesian navigation labels.
i18n/​locales/​fr-FR.json Adds French navigation labels.
i18n/​locales/​es-ES.json Adds Spanish navigation labels.
i18n/​locales/​en-US.json Adds English navigation labels.
i18n/​locales/​de-DE.json Adds German navigation labels.
i18n/​locales/​ar-MA.json Adds Arabic navigation labels.
config/​navs.ts Defines product groups, pool children, and documentation footer.
components/​top-nav-breadcrumb.tsx Uses the shared permission-aware breadcrumb builder.
components/​object/​list.tsx Adds a slot for bucket navigation.
components/​buckets/​scoped-header.tsx Combines bucket identity, actions, and shared navigation.
components/​buckets/​navigation.tsx Renders permitted bucket links and reveals the active destination.
components/​app-sidebar.tsx Renders grouped navigation, collapsed menus, and mobile link handling.
app/​(dashboard)/​sse/​page.tsx Renames the page title to Encryption & Keys.
app/​(dashboard)/​buckets/​page.tsx Adopts the shared bucket header.
app/​(dashboard)/​browser/​content.tsx Adds bucket navigation to object lists and previews.

Review effort: Balanced

Comment thread components/top-nav-breadcrumb.tsx Resolved
Render non-link breadcrumb ancestors as plain text so assistive technology announces only one current page. Replace source-string assertions with rendered regression coverage for pool pages, restricted bucket events, and object links.
@cxymds
cxymds merged commit d74c90e into main Nov 13, 2026
10 checks passed
@cxymds
cxymds deleted the cxymds/reorganize-console-navigation branch November 13, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants