Skip to content

fix: add missing article to the login hero headline - #301

Merged
cxymds merged 1 commit into
rustfs:mainfrom
joeyshi12:fix/login-hero-ai-era-copy
Nov 14, 2026
Merged

cxymds merged 1 commit into
rustfs:mainfrom
joeyshi12:fix/login-hero-ai-era-copy

Conversation

@joeyshi12

@joeyshi12 joeyshi12 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Description

The English login hero headline reads "Object storage for AI era", which is missing an article. The RustFS website says "Storage Built for the AI Era", so this changes the English string to "Object storage for the AI era". Only en-US changes; the Chinese headline from #288 is unaffected.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile   # exit 0
pnpm type-check                  # exit 0
pnpm lint                        # exit 0
pnpm format:check                # exit 0
pnpm test:run                    # 1059 passed, 0 failed

The existing login hero copy test in tests/lib/i18n-locales.test.js now expects the new string. Checked /auth/login/ at 1440x900 in Chromium: the headline wraps as "Object storage for the / AI era".

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

No linked issue. Follow-up to #288.

Screenshots (if applicable)

Before:

Login hero before

After:

Login hero after

Additional Notes

The hero is hidden below the lg breakpoint, so only the wide layout shows it.

The headline read "Object storage for AI era". The RustFS website uses "the AI era", so the English copy now matches.
@cxymds
cxymds merged commit 54938e7 into rustfs:main Nov 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants