Handle explicit directory entries during update archive unpacking#520
Merged
Conversation
ryanfowler
force-pushed
the
fix-archive-unpacking-errors
branch
from
6c3ee35 to
2341f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MkdirAllfor explicit directory entries in the Unix and Windows unpackers so archives with predeclared directories extract cleanly.os.O_TRUNCwhen writing Unix regular files to avoid leaving stale bytes behind on overwrite.Testing
go test -v ./internal/updatego test ./...