Skip to content

@W-24309704: Remove SF_TEMP_SHOW_SECRETS env var workaround - #1560

Merged
WillieRuemmele merged 1 commit into
mainfrom
ew/remove-secrets-env-var-workaround
Oct 16, 2026
Merged

WillieRuemmele merged 1 commit into
mainfrom
ew/remove-secrets-env-var-workaround

Conversation

@iowillhoit

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Removes the SF_TEMP_SHOW_SECRETS env var workaround. redactAuthFields now always redacts the access token and SFDX auth URL
  • Deletes the temp.envVarIsSet key from messages/secrets-redacted.md (keeps the permanent redacted.* keys)
  • Drops the env var reads and the associated warning blocks from org list auth, org login access-token, org login jwt, org login sfdx-url, and org login web
  • Updates unit tests to assert fields stay redacted and no SF_TEMP_SHOW_SECRETS warning is emitted even when the env var is set

What issues does this PR fix or reference?

@W-24309704@
forcedotcom/cli#3658

@iowillhoit
iowillhoit requested a review from a team as a code owner October 15, 2026 22:16
@WillieRuemmele
WillieRuemmele merged commit 5ad2ee7 into main Oct 16, 2026
16 checks passed
@WillieRuemmele
WillieRuemmele deleted the ew/remove-secrets-env-var-workaround branch October 16, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants