Skip to content

[3006.x] fire event at job start#65405

Closed
Legrems wants to merge 1 commit into
saltstack:3006.xfrom
ArcaniteSolutions:3006.x-fire-event-at-job-start
Closed

[3006.x] fire event at job start#65405
Legrems wants to merge 1 commit into
saltstack:3006.xfrom
ArcaniteSolutions:3006.x-fire-event-at-job-start

Conversation

@Legrems

@Legrems Legrems commented Oct 16, 2023

Copy link
Copy Markdown

What does this PR do?

We ran into some issues with a large amount of minions in our salt cluster. We wanted an ack from minions that they were starting job. The salt/job/<jid>/new wasn't enough, since it doesn't imply that the job will/have ever be started.

This PR make salt-minion fire an even when a minion start a job.

This code was meant to be deployed in our production, so the patch were made to be as faulty resistent as possible (hence the decorators for *args and **kwargs, in a non-existent file)

What issues does this PR fix or reference?

Unsure if any similar issue was created for this particular wanted behaviour

New Behavior

The salt-minion now fire an event under custom/job/<jid>/started/<minion_id> when starting a job.

Merge requirements satisfied?

  • Docs
  • Changelog => No issue for this?
  • Tests written/updated
    • No tests written, but i'm open to writting them if this is a wanted feature for salt

Commits signed with GPG?

Yes

@Legrems Legrems requested a review from a team as a code owner October 16, 2023 10:28
@Legrems Legrems requested review from felippeb and removed request for a team October 16, 2023 10:28
@welcome

welcome Bot commented Oct 16, 2023

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment Bot changed the title fire event at job start [3006.x] fire event at job start Oct 16, 2023
@Legrems Legrems force-pushed the 3006.x-fire-event-at-job-start branch from 8df6467 to d0310d3 Compare October 16, 2023 10:30
@s0undt3ch

Copy link
Copy Markdown
Contributor

Personally, I'd prefer calling it explicitly instead of using a decorator...
I know its a lot of duplicate code.

Alternatively, create a utility function and call that out in the function bodies(instead of using the decorator).

@dwoz dwoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new feature and the PR should be against master, not 3006.x

@dwoz dwoz added this to the Sulfur v3006.6 milestone Dec 11, 2023
@dwoz

dwoz commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

This is a new feature and the PR should be against master, not 3006.x

@Legrems Are you able to port this to the master branch please?

@dwoz dwoz modified the milestones: Sulfur v3006.6, Sulfur v3006.9 Jun 22, 2024
@dwoz dwoz requested a review from a team as a code owner March 20, 2025 21:24

@twangboy twangboy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be created against the master branch. Also needs a changelog and some tests.

@dwoz dwoz modified the milestones: Sulfur v3006.12, Sulfer v3006.13 Jun 13, 2025
@twangboy twangboy added the pending-changes The pull request needs additional changes before it can be merged label Jul 2, 2025
@twangboy twangboy added test:full Run the full test suite needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog needs-rebase Needs to be rebased, against either the current branch or a different one labels Jul 9, 2025
@twangboy twangboy modified the milestones: Argon v3008.0, Argon v3008.1 Jun 5, 2026
@dwoz

dwoz commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This was implimented: #69013

@dwoz dwoz closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changelog needs-rebase Needs to be rebased, against either the current branch or a different one needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases pending-changes The pull request needs additional changes before it can be merged test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants