[3006.x] fire event at job start#65405
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
8df6467 to
d0310d3
Compare
|
Personally, I'd prefer calling it explicitly instead of using a decorator... Alternatively, create a utility function and call that out in the function bodies(instead of using the decorator). |
dwoz
left a comment
There was a problem hiding this comment.
This is a new feature and the PR should be against master, not 3006.x
@Legrems Are you able to port this to the master branch please? |
twangboy
left a comment
There was a problem hiding this comment.
Needs to be created against the master branch. Also needs a changelog and some tests.
|
This was implimented: #69013 |
What does this PR do?
We ran into some issues with a large amount of minions in our salt cluster. We wanted an ack from minions that they were starting job. The
salt/job/<jid>/newwasn't enough, since it doesn't imply that the job will/have ever be started.This PR make salt-minion fire an even when a minion start a job.
This code was meant to be deployed in our production, so the patch were made to be as faulty resistent as possible (hence the decorators for
*argsand**kwargs, in a non-existent file)What issues does this PR fix or reference?
Unsure if any similar issue was created for this particular wanted behaviour
New Behavior
The salt-minion now fire an event under
custom/job/<jid>/started/<minion_id>when starting a job.Merge requirements satisfied?
Commits signed with GPG?
Yes