Repository navigation
Conversation
createAppIconsJson inserted app labels into the JSON without escaping. A label that contains a line break or a quote produces invalid JSON, so the Mac app fails to decode the whole appIcons message and drops it without any visible error. Every sync fails the same way, which leaves the Apps grid and the per-app notification list on the Mac empty. Example: the launcher label of kr.co.dgb.dgbm is "iM뱅크\n(아이엠)". Use the existing escape() helper for app names, and make escape() also handle tabs and the other control characters JSON does not allow unescaped.
…json fix: escape app names in app icons JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces background clipboard sync functionality by adapting an approach from the ClipSync project, and updates the app to version 4.1.0. It also improves user-facing documentation and UI to credit third-party sources and explain new permissions. Additionally, there are minor improvements to QuickShare advertising logic for stability.
Background Clipboard Sync Integration:
ClipboardGhostActivity(adapted from ClipSync) to enable background clipboard reading on Android 10+ by using an invisible activity to momentarily gain focus and access the clipboard. This is triggered by a new accessibility service. [1] [2] [3]ClipboardGhostActivityandClipboardAccessibilityServicein theAndroidManifest.xml. [1] [2]Licensing and Attribution:
THIRD_PARTY_NOTICES.mdfile to credit ClipSync and include its MIT license, with references to the adapted background clipboard sync code.README.mdacknowledgements to credit ClipSync for the clipboard sync approach.Permissions and User Interface:
QuickShare Improvements:
Versioning:
build.gradle.kts.