Update maddy to simplify regexes, so VS2026 won't complain. - #488
Merged
Merged
Conversation
A round-tripped notes from Biomodels 12 was causing maddy to run into throws from the regexes when compiled with VS2026 (not 2022, nor from any other compiler). The new regexes are simpler, and should work for more complicated strings, like the one found in biomodels 12.
There are several biomodels with nonbreaking spaces: this stripping was removing the second byte of them.
Member
Author
|
Also needed a different fix in html2md: it was stripping the second character of UTF-8 non-breaking spaces. |
fbergmann
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A round-tripped notes from Biomodels 12 was causing maddy to run into throws from the regexes when compiled with VS2026 (not 2022, nor from any other compiler). The new regexes are simpler, and should work for more complicated strings, like the one found in biomodels 12. Added a test with the Cursed String.