Update datetime columns to perserve their original format - #931
Open
sarahmish wants to merge 8 commits into
Open
Update datetime columns to perserve their original format#931sarahmish wants to merge 8 commits into
sarahmish wants to merge 8 commits into
Conversation
sarahmish
requested review from
R-Palazzo and
frances-h
and removed request for
a team
September 3, 2026 16:44
This was
linked to
issues
Sep 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## issue-924-unknown-denominator #931 +/- ##
=================================================================
+ Coverage 95.68% 95.70% +0.01%
=================================================================
Files 122 122
Lines 5313 5331 +18
=================================================================
+ Hits 5084 5102 +18
Misses 229 229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
R-Palazzo
reviewed
Sep 3, 2026
R-Palazzo
left a comment
R-Palazzo
left a comment
Contributor
There was a problem hiding this comment.
Looks good
I just left minor comments
| datetime_columns.append(column) | ||
|
|
||
| return pd.read_csv(path, parse_dates=datetime_columns) | ||
| return pd.read_csv(path) |
Contributor
There was a problem hiding this comment.
Could we remove the metadata from the method's inputs?
|
|
||
|
|
||
| @pytest.fixture | ||
| def converted_datetime_single_table_demo(): |
Contributor
There was a problem hiding this comment.
Could we name it data_single_table_demo instead? Since it’s used in many places that don’t specifically focus on datetime conversion.
| 1.0, | ||
| np.nan, | ||
| 1.0, | ||
| np.nan, |
sarahmish
force-pushed
the
issue-924-unknown-denominator
branch
from
September 4, 2026 17:27
bf4006d to
07e8d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #925
Resolve #926