Repository navigation
Conversation
AI-Assisted: yes (Cursor AI)
AI-Assisted: no
AI-Assisted: yes (Cursor AI)
AI-Assisted: yes (Cursor AI)
The dissector did not match the protocol as implemented by zenohd, so it could not decode real traffic: transport and network message IDs were outside their actual ranges, header flags sat at the wrong bit offsets, the Zenoh ID was length prefixed instead of packed into the zid_len nibble, timestamps were read as a single opaque buffer rather than a zint counter plus a source ID, extensions had no TLV or chaining support, and stream links were missing the 16 bit little endian batch length prefix. Rework every layer (scouting, transport, network with its declarations, and the Put/Del/Query/Reply/Err bodies) following commons/zenoh-protocol and commons/zenoh-codec, add the zint, zbuf, encoding, timestamp and consolidation field types, chain extensions through their more bit, and split batches into ZenohBatch for datagram links and ZenohStreamBatch for stream links. Optional fields announced by a header flag are now emitted as soon as they are given a value, and the flag is computed while building. Validated against zenohd 1.9.0: every captured payload of a pub/sub, query, liveliness and delete session dissects without undecoded bytes and rebuilds byte for byte. Those payloads are kept as regression vectors in the test file, which now covers the field codecs, each message type against spec derived bytes, batch framing, port bindings and the behaviour on fuzzed and truncated input. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the removed orb helper with byte indexing. AI-Assisted: yes (OpenCode, GPT-6.1)
Reassemble complete TCP batches, decode Shm payload slices, and retain nested edits and explicit extension bits. Set scouting destination ports for concrete message builders. AI-Assisted: yes (OpenCode, GPT-6.1)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5084 +/- ##
===========================================
- Coverage 80.55% 47.50% -33.05%
===========================================
Files 375 376 +1
Lines 98399 98887 +488
===========================================
- Hits 79261 46974 -32287
- Misses 19138 51913 +32775
🚀 New features to boost your workflow:
|
Track child wire bytes alongside field state for packet-list cache invalidation. Read conditional slices once when summarizing fuzzed Put messages. AI-Assisted: yes (OpenCode, GPT-6.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.