Skip to content

fix: deliver poller events with MakeCallback#239

Open
Azq2 wants to merge 1 commit into
serialport:mainfrom
siemens-mobile-hacks:fix/poller-makecallback
Open

fix: deliver poller events with MakeCallback#239
Azq2 wants to merge 1 commit into
serialport:mainfrom
siemens-mobile-hacks:fix/poller-makecallback

Conversation

@Azq2

@Azq2 Azq2 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fix native poller callbacks to use MakeCallback, so promise continuations scheduled by readable events run immediately instead of waiting for a later event-loop tick.

Example of bug:

    serialport/bindings-cpp/unixRead readable fired! +11ms <--- debug inside readable()
    serialport/bindings-cpp/unixRead Starting read +10s <--- await readable() is delayed until external setTimeout(() => { /* noop */ }, 10000) finished

I saw this problem when EAGAIN happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant