html5ever: avoid unnecessary attribute clone in TreeBuilder::insert_element. - #766
Open
niklak wants to merge 2 commits into
Open
html5ever: avoid unnecessary attribute clone in TreeBuilder::insert_element.#766niklak wants to merge 2 commits into
TreeBuilder::insert_element.#766niklak wants to merge 2 commits into
Conversation
niklak
force-pushed
the
refactor/tree-builder-insert-element
branch
from
August 5, 2026 10:51
92fab3e to
a81c906
Compare
…lder::insert_element`.
niklak
force-pushed
the
refactor/tree-builder-insert-element
branch
from
August 5, 2026 11:04
a81c906 to
ad725e8
Compare
mrobinson
approved these changes
Aug 6, 2026
mrobinson
left a comment
mrobinson
left a comment
Member
There was a problem hiding this comment.
Looks good with some stylistic nits:
| ref prev_element, | ||
| } => (element.clone(), Some(prev_element.clone())), | ||
| }; | ||
|
|
Co-authored-by: Martin Robinson <martin@abandonedwig.info> Signed-off-by: Mykola Humanov <gnk667@proton.me>
niklak
force-pushed
the
refactor/tree-builder-insert-element
branch
from
August 6, 2026 09:42
13a5833 to
9958c09
Compare
mrobinson
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordered code in
impl TreeBuilder<Handle, Sink>::insert_elementto avoid an unnecessary clone of tag attributes.