SG-43677 Fix hooks to support multiple keyword arguments - #144
Merged
carlos-villavicencio-adsk merged 1 commit intoJun 11, 2026
Merged
Conversation
This was referenced Jun 11, 2026
julien-lang
reviewed
Jun 11, 2026
Member
There was a problem hiding this comment.
Should we remove this file? I'm surprised we missed it!
| # public interface - to be overridden by deriving classes | ||
|
|
||
| def generate_actions(self, sg_publish_data, actions, ui_area): | ||
| def generate_actions(self, sg_publish_data, actions, ui_area, **kwargs): |
Contributor
Author
There was a problem hiding this comment.
Because I'm injecting a new argument to the hook for flowam integration to work.
This is not needed on all DCCs (i.e. 3ds, photoshop) but it crashes due to the unexpected argument. So this is just adding the placeholder.
You can see the difference on this file and compare it to tk-maya_actions.py to have a better picture.
5 tasks
Contributor
Author
|
Merging this. Any further updates can be done against #137 |
carlos-villavicencio-adsk
merged commit Jun 11, 2026
777b988
into
ticket/SG-43456_migration_1
12 of 25 checks passed
carlos-villavicencio-adsk
added a commit
that referenced
this pull request
Jul 8, 2026
* Add MEDM abstractions and utilities * Apply black * Apply black - pre-commit version * Add remaining types * DRY * SG-43457 [Part2] Migration of MEDM main logic and resources (#138) * Migration of the MEDM resources * Migration of MEDM core logic * Fix thumbnail display on version history * Tentative wrap-up * Format * Fix CI: add missing fw * Update Azure pipelines additional_repositories * Revert framework additions for CI * Comment framework for CI * Test CI green * Add remaining types * Fix types * Code review feedback * Move `DRAFT_VERSION_IDENTIFIER` to constants * SG-43458 [Part3] Config Hooks (#139) * Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143) * SG-43677 Fix hooks to support multiple kwargs (#144) * SG-43459 Migrate Build scene/template workflows (#145) * Remove framework dependency from dialogs classes * Migrate build asset/template workflows * Remove more references * Use sandbox functions * Update references on models * Migrate thumbnail utilities * Use more sandbox functions * Finish migrating framework-floam references * Update references from sgtk.flowam.create * Remove framework loading * Rename fucntion to get FlowAMActions instance * Rename `am_base_obj` to `flowam_actions` * Latest Updates * Finish clean-up * Update imports * Tested reference link and download workflows * Finished testing build scene, open, reference, discard. * Tested create template workflow * Add tk_core_ref value for testing * Format * Fix fixture * remove migrated methods * Rename `medm` directory to `flowam` * Removed `enable_flowam` setting * Get rid of `FlowAMActions` dependency injection and use app level module * Update core new definitions * Fix format * Handle error * Remove dead code * Update references, rename variables * Fix discard draft logic * Format * Update reference sequence * Improved `CreateReferenceError` * CR fixes * Fix method signature * Import flowam module just to be safe * Add codecov.yml file * Exclude ui files from codecov * Fix paths * Add more files * Add hosts validationo * feat: [SG-43419] Launch publisher via engine command with single_file_mode support (#147) Replace direct app lookup + non-existent _set_context() call with the established engine command callback pattern. Grab the publisher app from the matched command's properties to call show_dialog() directly, passing single_file_mode=True when the action is a Flow AM republish ("publish"), so the dialog restricts users to dropping or browsing a single file. * Try to add support to older cores * Fix format * Update conditionals * Point CI to tk-core master * Remove config dependency for entity mapping (#148) * Remove config dependency for entity mapping * Code review feedback * Actions reorg * Update workfile actions * Format! --------- Co-authored-by: Ming Chen <ming.chen@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch: #137
DCCs that are not supported with FlowAM integration crashes their hooks due to unexpected arguments. This PRs addresses this issue by just adding
**kwargsand silently ignoring them when not needed.