SG-43459 Migrate Build scene/template workflows by carlos-villavicencio-adsk · Pull Request #145 · shotgunsoftware/tk-multi-loader2

carlos-villavicencio-adsk · 2026-06-15T21:15:19Z

Base branch #137

Requirements

Description

This will prevent having these workflows dependant from tk-framework-flowam.

TODO

Remove references for framework-flowam on flowam_actions.py
Remove references for framework-flowam on entity, latest publish, and publish history models.
Remove requirement on info.yml
Tested on Maya
Tested on Desktop
Remove tk_core_ref from azure-pipelines.yml

codecov · 2026-06-17T19:05:39Z

Codecov Report

❌ Patch coverage is 26.23318% with 329 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ticket/SG-43456_migration_1@777b988). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
python/tk_multi_loader/flowam/create.py	22.28%	143 Missing ⚠️
python/tk_multi_loader/flowam/reference.py	12.30%	57 Missing ⚠️
python/tk_multi_loader/flowam/file.py	12.69%	55 Missing ⚠️
python/tk_multi_loader/flowam/flowam_actions.py	13.63%	38 Missing ⚠️
python/tk_multi_loader/build_asset_dialog.py	45.45%	6 Missing ⚠️
python/tk_multi_loader/flowam/entity_model.py	53.84%	6 Missing ⚠️
...thon/tk_multi_loader/flowam/latestpublish_model.py	62.50%	6 Missing ⚠️
python/tk_multi_loader/flowam/template_queries.py	60.00%	4 Missing ⚠️
python/tk_multi_loader/build_template_dialog.py	57.14%	3 Missing ⚠️
python/tk_multi_loader/dialog.py	25.00%	3 Missing ⚠️
... and 4 more

Additional details and impacted files

@@                      Coverage Diff                       @@
##             ticket/SG-43456_migration_1     #145   +/-   ##
==============================================================
  Coverage                               ?   19.18%           
==============================================================
  Files                                  ?       51           
  Lines                                  ?     4842           
  Branches                               ?        0           
==============================================================
  Hits                                   ?      929           
  Misses                                 ?     3913           
  Partials                               ?        0

Flag	Coverage Δ
Linux	`19.18% <26.23%> (?)`
Python-3.10	`19.18% <26.23%> (?)`
Python-3.11	`19.18% <26.23%> (?)`
Python-3.13	`19.18% <26.23%> (?)`
Python-3.9	`19.18% <26.23%> (?)`
Windows	`19.18% <26.23%> (?)`
macOS	`19.18% <26.23%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chenm1adsk

Left some question of improvement that I am not sure if we should aim for in the scope of this ticket.

chenm1adsk · 2026-06-19T04:47:44Z

        if len(actions) == 0:
            actions.extend(list(mappings.get("All", [])))


Not introduced by this PR but as I mentioned in phase1 PR, this will change the behaviour of when to append actions in "All", we shouldn't introduce to tk-multi-loader2.

chenm1adsk · 2026-06-19T05:50:15Z

-        enable_flowam = app.get_setting("enable_flowam", False)
-        if enable_flowam:
-            am_base_obj = kwargs.get("am_base_obj")
+        if self.parent.context.flow_project_id:


I feel like it is better to just create a function to group flow logic.
For example create a _flow_execute_action and called it when flow project id exists

yungsiow

Looks good! Thanks Charlie!

* Add MEDM abstractions and utilities * Apply black * Apply black - pre-commit version * Add remaining types * DRY * SG-43457 [Part2] Migration of MEDM main logic and resources (#138) * Migration of the MEDM resources * Migration of MEDM core logic * Fix thumbnail display on version history * Tentative wrap-up * Format * Fix CI: add missing fw * Update Azure pipelines additional_repositories * Revert framework additions for CI * Comment framework for CI * Test CI green * Add remaining types * Fix types * Code review feedback * Move `DRAFT_VERSION_IDENTIFIER` to constants * SG-43458 [Part3] Config Hooks (#139) * Migrate config hooks * Add type annotations * Wrap `get_am_base_obj` into the loader action manager * Wraps constant * SG-43460 [Part4] Build dialogs and template utils (#140) * Migrate `BuildAssetDialog` and `BuildTemplateDialog` classes * Migrate template helpers * Code review feedback * Update setting name * Change MEDM to FlowAM in comments * Replace MEDM in log messages * SG-43626 Fix bug when details panel collapses/expands (#142) * Fix bug when details panel collapses/expands * SG-43627 Fix empty space gap on the details panel (#143) * SG-43677 Fix hooks to support multiple kwargs (#144) * SG-43459 Migrate Build scene/template workflows (#145) * Remove framework dependency from dialogs classes * Migrate build asset/template workflows * Remove more references * Use sandbox functions * Update references on models * Migrate thumbnail utilities * Use more sandbox functions * Finish migrating framework-floam references * Update references from sgtk.flowam.create * Remove framework loading * Rename fucntion to get FlowAMActions instance * Rename `am_base_obj` to `flowam_actions` * Latest Updates * Finish clean-up * Update imports * Tested reference link and download workflows * Finished testing build scene, open, reference, discard. * Tested create template workflow * Add tk_core_ref value for testing * Format * Fix fixture * remove migrated methods * Rename `medm` directory to `flowam` * Removed `enable_flowam` setting * Get rid of `FlowAMActions` dependency injection and use app level module * Update core new definitions * Fix format * Handle error * Remove dead code * Update references, rename variables * Fix discard draft logic * Format * Update reference sequence * Improved `CreateReferenceError` * CR fixes * Fix method signature * Import flowam module just to be safe * Add codecov.yml file * Exclude ui files from codecov * Fix paths * Add more files * Add hosts validationo * feat: [SG-43419] Launch publisher via engine command with single_file_mode support (#147) Replace direct app lookup + non-existent _set_context() call with the established engine command callback pattern. Grab the publisher app from the matched command's properties to call show_dialog() directly, passing single_file_mode=True when the action is a Flow AM republish ("publish"), so the dialog restricts users to dropping or browsing a single file. * Try to add support to older cores * Fix format * Update conditionals * Point CI to tk-core master * Remove config dependency for entity mapping (#148) * Remove config dependency for entity mapping * Code review feedback * Actions reorg * Update workfile actions * Format! --------- Co-authored-by: Ming Chen <ming.chen@autodesk.com>

carlos-villavicencio-adsk added 14 commits June 15, 2026 12:47

Remove framework dependency from dialogs classes

559160f

Migrate build asset/template workflows

4da2df7

Remove more references

eb20c5a

Use sandbox functions

9c0d72d

Update references on models

5f23754

Migrate thumbnail utilities

c1df4e3

Use more sandbox functions

1657118

Finish migrating framework-floam references

5952719

Update references from sgtk.flowam.create

77efc5e

Remove framework loading

cb88ca1

Rename fucntion to get FlowAMActions instance

74da4d5

Rename am_base_obj to flowam_actions

e3c5ba5

Latest Updates

fc27088

Finish clean-up

4a3f936

carlos-villavicencio-adsk mentioned this pull request Jun 17, 2026

SG-43456 [Phases 1-2] Enable FlowAM integration #137

Merged

5 tasks

carlos-villavicencio-adsk added 7 commits June 17, 2026 09:22

Update imports

9fad77e

Tested reference link and download workflows

8dfe63d

Finished testing build scene, open, reference, discard.

7e52826

Tested create template workflow

3d30405

Add tk_core_ref value for testing

7d66ea0

Format

a7329ae

Fix fixture

19a5298

carlos-villavicencio-adsk added 4 commits June 17, 2026 14:13

remove migrated methods

10c7615

Rename medm directory to flowam

d04aa23

Removed enable_flowam setting

c489bc4

Get rid of FlowAMActions dependency injection and use app level module

97c5e03

carlos-villavicencio-adsk marked this pull request as ready for review June 18, 2026 15:22

carlos-villavicencio-adsk added 2 commits June 18, 2026 13:14

Update core new definitions

43df636

Fix format

f5c1d84

yungsiow reviewed Jun 18, 2026

View reviewed changes

Comment thread hooks/tk-houdini_actions.py Outdated

chenm1adsk reviewed Jun 19, 2026

View reviewed changes

carlos-villavicencio-adsk added 2 commits June 19, 2026 09:26

Handle error

8e4a4af

Remove dead code

fa1d044

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/file.py Outdated

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/flowam_actions.py Outdated

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/flowam_actions.py Outdated

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/reference.py Outdated

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/reference.py

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/reference.py

carlos-villavicencio-adsk added 5 commits June 19, 2026 12:00

Update references, rename variables

9becc41

Fix discard draft logic

71eedd4

Format

12e841f

Update reference sequence

113d946

Improved CreateReferenceError

b74125e

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/reference.py Outdated

yungsiow reviewed Jun 19, 2026

View reviewed changes

Comment thread python/tk_multi_loader/flowam/reference.py Outdated

CR fixes

2974c6b

carlos-villavicencio-adsk mentioned this pull request Jun 19, 2026

SG-43652 [Phase 2] Migrate FlowAM integration shotgunsoftware/tk-multi-breakdown2#91

Merged

4 tasks

carlos-villavicencio-adsk requested a review from yungsiow June 22, 2026 13:21

carlos-villavicencio-adsk added 2 commits June 22, 2026 08:31

Fix method signature

ce26987

Import flowam module just to be safe

38e0e20

yungsiow approved these changes Jun 22, 2026

View reviewed changes

carlos-villavicencio-adsk merged commit 1fd1069 into ticket/SG-43456_migration_1 Jun 22, 2026
27 checks passed

carlos-villavicencio-adsk deleted the ticket/SG-43459_migration_phase2 branch June 22, 2026 20:28

		if len(actions) == 0:
		actions.extend(list(mappings.get("All", [])))

Uh oh!

Conversation

carlos-villavicencio-adsk commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements

Description

TODO

Uh oh!

codecov Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

chenm1adsk left a comment

Choose a reason for hiding this comment

Uh oh!

chenm1adsk Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenm1adsk Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yungsiow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carlos-villavicencio-adsk commented Jun 15, 2026 •

edited

Loading

codecov Bot commented Jun 17, 2026 •

edited

Loading