cli: output JSON without escaping non-ASCII characters#741
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Closes simonw#625. json.dumps defaults to ensure_ascii=True, so output_rows emitted '\u65e5\u672c\u8a9e' instead of '日本語' for Japanese. The CSV path already shows the characters verbatim - the JSON path should too. Pass ensure_ascii=False so the bytes match what the CSV output (and the database itself) holds. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #625.
json.dumpsdefaults toensure_ascii=True, sooutput_rowsemitted日本語instead of日本語for Japanese rows. The CSV path already shows the characters verbatim — the JSON path should too. Passensure_ascii=Falseso the bytes match what the CSV output (and the database itself) holds.📚 Documentation preview 📚: https://sqlite-utils--741.org.readthedocs.build/en/741/