Skip to content

[Mage] Fire mage 12.1 set bonus #11516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lucasmingus wants to merge 2 commits into
base: midnight
Choose a base branch
from
Open

[Mage] Fire mage 12.1 set bonus #11516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef9ebcf
[Mage] Implementation of 12.1 Tier Set Bonuses
Lucasmingus Jun 19, 2026
89f71c9
added check
Lucasmingus Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion engine/class_modules/sc_mage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,7 +2384,13 @@ struct hot_streak_spell_t : public custom_state_spell_t<fire_mage_spell_t, hot_s
if ( p()->buffs.hot_streak->check() || p()->buffs.hyperthermia->check() )
return 0_ms;

return custom_state_spell_t::execute_time();
timespan_t t = custom_state_spell_t::execute_time();

// Fire Mage 12.1 Set Bonus 4pc
if ( p()->sets->has_set_bonus( MAGE_FIRE, MID2, B4 ) && p()->buffs.pyroclasm->check() )
t *= 1.0 + p()->buffs.pyroclasm->data().effectN( 3 ).percent();

return t;
}

void snapshot_state( action_state_t* s, result_amount_type rt ) override
Expand All @@ -2399,6 +2405,10 @@ struct hot_streak_spell_t : public custom_state_spell_t<fire_mage_spell_t, hot_s

c += p()->buffs.hyperthermia->check_value();

// Fire Mage 12.1 Set Bonus 2pc
if ( p()->sets->has_set_bonus( MAGE_FIRE, MID2, B2 ) && p()->buffs.pyroclasm->check() )
c += p()->buffs.pyroclasm->data().effectN( 2 ).percent();

return c;
}

Expand Down
Loading