Repository navigation
Fix learner screenshot delivery and startup races - #4
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
a-a-ron
force-pushed
the
a-a-ron-add-activity-screenshots
branch
from
September 30, 2026 18:38
be1ac7a to
ee2c12c
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Cancelling active Step 0 runs can leave initialization partially completed.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates learner step delivery to render valid image URLs and reduce duplicate exercise initialization.
Changes:
- Adds repository-local image URL rendering for Steps 1–5.
- Reuses existing exercise issues during startup.
- Adds Step 0 concurrency handling.
| File | Description |
|---|---|
.github/workflows/0-start-exercise.yml |
Adds issue reuse, concurrency, and Step 1 rendering. |
.github/workflows/1-step.yml |
Renders Step 2 image URLs. |
.github/workflows/2-step.yml |
Renders Step 3 image URLs. |
.github/workflows/3-step.yml |
Renders Step 4 image URLs. |
.github/workflows/4-step.yml |
Renders Step 5 image URLs. |
.github/scripts/render_step.py |
Converts local image paths to raw repository URLs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| concurrency: | ||
| group: start-exercise-${{ github.repository }} | ||
| cancel-in-progress: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
octocat/learner-copypython3 -m pytest -q(starter state)git diff --checkFollow-up to #3, which was merged before these end-to-end learner-run findings were applied.