ci: do not fail CI when Codecov test-results upload errors#1552
Merged
Conversation
The "Upload test results to Codecov" step in the unittest job is a best-effort reporting side-channel, not a gate on code correctness. Set fail_ci_if_error to false so a transient Codecov outage or upload error no longer fails an otherwise passing build. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
WilliamBergamin
added
the
github_actions
zimeg
approved these changes
Jul 20, 2026
zimeg
left a comment
zimeg
left a comment
Member
There was a problem hiding this comment.
👁️🗨️ @WilliamBergamin Let's keep main green with passing CI!
| with: | ||
| directory: ./reports/ | ||
| fail_ci_if_error: true | ||
| fail_ci_if_error: false |
Member
There was a problem hiding this comment.
🤖 praise: An amazing option to toggle!
WilliamBergamin
enabled auto-merge (squash)
July 20, 2026 16:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 228 228
Lines 7285 7285
=======================================
Hits 6669 6669
Misses 616 616 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
unittestjob's Upload test results to Codecov step currently setsfail_ci_if_error: true, so a transient Codecov outage or upload hiccup fails the whole CI pipeline even when every test passed.Uploading test results to Codecov is a best-effort reporting side-channel, not a gate on code correctness. This PR flips that step to
fail_ci_if_error: false— a "send and forget" upload — so a third-party upload failure no longer reddens an otherwise green build.Scope is intentionally limited to the test-results upload. The separate coverage upload in the
codecovjob is left unchanged.Testing
fail_ci_if_error: falseis a documentedcodecov/codecov-actioninput; the workflow YAML still parses.Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
./scripts/install_all_and_run_tests.shafter making the changes. (CI-only change; no source code affected.)🤖 Generated with Claude Code