Skip to content

chore: block @dependabot updates to @types/node@26#2634

Merged
zimeg merged 2 commits into
mainfrom
chore/node-26-ci-and-dependabot
Jun 26, 2026
Merged

chore: block @dependabot updates to @types/node@26#2634
zimeg merged 2 commits into
mainfrom
chore/node-26-ci-and-dependabot

Conversation

@zimeg

@zimeg zimeg commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary

This pull request caps @types/node for the Node Slack SDK so Dependabot won't bump it to v26.

  • Extends the @types/node Dependabot ignore rules across all packages to also block 26.x (framework packages stay on the v18 line; examples on v24).

The Node 26 CI matrix addition was split out into #2635 so it can land independently.

Requirements

@changeset-bot

changeset-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4652a74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (fefeb07) to head (4652a74).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2634   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          63       63           
  Lines       10256    10256           
  Branches      452      452           
=======================================
  Hits         9118     9118           
  Misses       1117     1117           
  Partials       21       21           
Flag Coverage Δ
cli-hooks 88.90% <ø> (ø)
cli-test 88.90% <ø> (ø)
logger 88.90% <ø> (ø)
oauth 88.90% <ø> (ø)
socket-mode 88.90% <ø> (ø)
web-api 88.90% <ø> (ø)
webhook 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg self-assigned this Jun 24, 2026
@zimeg zimeg added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch labels Jun 24, 2026
@zimeg zimeg force-pushed the chore/node-26-ci-and-dependabot branch from 79ba99b to 21a7db2 Compare June 24, 2026 05:10
@zimeg zimeg mentioned this pull request Jun 24, 2026
2 tasks
@zimeg zimeg changed the title chore: add Node 26 to CI and block @types/node v26 in Dependabot chore: block Dependabot updates to @types/node v26 Jun 24, 2026
@zimeg zimeg changed the title chore: block Dependabot updates to @types/node v26 chore: block @dependabot updates to @types/node@26 Jun 24, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓 A note on current changes but I think we can follow up with better documented updating paths!

Comment thread .github/dependabot.yml
Comment on lines +250 to +254
ignore:
- dependency-name: "@types/node"
versions:
- "25.x"
- "26.x"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 note: Included examples don't use @types/node at the moment but we hope to capture our version patterns with this addition!

@zimeg zimeg marked this pull request as ready for review June 24, 2026 06:08
@zimeg zimeg requested a review from a team as a code owner June 24, 2026 06:08
@zimeg

zimeg commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

@mwbrooks Let's celebrate ongoing stable versions with this merge 🎁 ✨

@zimeg zimeg merged commit 70cec0c into main Jun 26, 2026
12 checks passed
@zimeg zimeg deleted the chore/node-26-ci-and-dependabot branch June 26, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants