PRIV-546: node-measured round-trip metrics for ConfidentialModule#23037
Open
nadahalli wants to merge 3 commits into
Open
PRIV-546: node-measured round-trip metrics for ConfidentialModule#23037nadahalli wants to merge 3 commits into
nadahalli wants to merge 3 commits into
Conversation
ConfidentialModule.Execute emitted nothing, so there was no trusted signal for the enclave round-trip. The enclave.* metrics are node-forwarded but non-attested; this adds two node-measured (trusted) instruments around the doRequest call: platform_engine_confidential_execution_time_ms (histogram) platform_engine_confidential_execution_failures (counter) labeled by workflowID/workflowOwner/workflowName. New metric names, so no overload of existing classic dashboards/alerts.
Contributor
|
✅ No conflicts with other open PRs targeting |
Move the ConfidentialModule metrics into the enclave* namespace (enclave_execution_time_ms, enclave_execution_failures) so all confidential-workflow metrics stay out of the classic platform_engine_* namespace, per the separate-namespace decision. Add TestConfidentialModule_Execute_Metrics: injects a ManualReader-backed meter and asserts the duration histogram records on success and the failure counter increments (with duration still recorded) on an enclave error.
product-security-plaid-production
Bot
requested review from
bolekk,
pavel-raykov and
vyzaldysanchez
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ConfidentialModule.Executeemitted no metrics, so there was no trusted signal for the enclave round-trip. The confidential metrics forwarded from the enclave (enclave.*) are re-emitted node-side but are non-attested (the host can tamper with them). This adds two node-measured, trusted instruments around thedoRequestenclave call:enclave_execution_time_ms(histogram)enclave_execution_failures(counter)labeled by
workflowID/workflowOwner/workflowName.Notes
enclave*namespace (notplatform_engine_*), keeping all confidential-workflow metrics out of the classic namespace per the separate-namespace decision, so no classic dashboards/alerts are touched.beholder.GetMeter(), matching the syncer'snewMetricspattern.newConfidentialModuleMetricstakes ametric.Meterso tests can inject a reader.TestConfidentialModule_Execute_Metricsinjects aManualReader-backed meter and asserts the duration histogram records on success and the failure counter increments (duration still recorded) on an enclave error.Completes the node-side item tracked in the PRIV-546 metrics comment; the enclave-side
enclave.*metrics landed in confidential-compute #397/#403.