Skip to content

No mstate in scene is forbidden - #130

Open
bakpaul wants to merge 1 commit into
sofa-framework:masterfrom
bakpaul:26_09_no_mstate_eq_error
Open

bakpaul wants to merge 1 commit into
sofa-framework:masterfrom
bakpaul:26_09_no_mstate_eq_error

Conversation

@bakpaul

@bakpaul bakpaul commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

If no mstate is found then an error is thrown in write mode, and a failure in compare.

I did'nt touch the legacy code because it is legacy, but ideally it shouldn't allow empty mstate list neither.

@fredroy fredroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is raising an issue for Regression for me ; what if the regression scene just contains a VisualModel, or an other state (if one day there will be other meaningful State?)
Maybe we should consider the broader State than the Mechanical Object

@bakpaul

bakpaul commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

You are right, and this would also require a bit more info than the id of the state for the reference file. I have work on adding meta data to reference files, I think that adding the unique identifier (aka its full path in the scene) is a must have to enable using any quind of state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants