Skip to content

Remove borsh #11

Open
Open
Remove borsh#11

Description

@kevinheavey
kevinheavey
opened on Aug 17, 2024

borsh is slow to compile and contributes to dependency hell in a big way. solana-config-program doesn't use borsh, and neither does this new version of the program - it's only in the client. Nothing external will break if we remove it from the client now

Activity

  1. wowinter13 commented on Mar 3, 2025

    @wowinter13
    wowinter13
    on Mar 3, 2025
    Contributor

    I suppose this one could be closed? It looks like it was addressed.

    @buffalojoec ?

  2. buffalojoec commented on Mar 4, 2025

    @buffalojoec
    buffalojoec
    on Mar 4, 2025
    Contributor

    I suppose this one could be closed? It looks like it was addressed.

    @buffalojoec ?

    Nope, unfortunately:

    config/clients/rust/Cargo.toml

    Line 16 in 3d8e19a

    borsh = { workspace = true }

  3. wowinter13 commented on Mar 4, 2025

    @wowinter13
    wowinter13
    on Mar 4, 2025
    Contributor

    Ah sorry
    I checked program/Cargo.toml

    As @kevinheavey mentioned

    it's only in the client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions