Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateTokenMetadataInstructioninclients/jschecks the name, symbol and URI limits withtokenName.length > 32,tokenSymbol.length > 10andtokenUri.length > 200. These count UTF-16 code units, but the Metaplex limits are in bytes (the CLI'sis_valid_token_*already usess.len()). So a non-ASCII value can pass the client check and then fail on chain. For example,'あ'.repeat(11)is 11 characters but 33 bytes: the client builds the instruction, and the transaction fails with Metaplexcustom program error: 0xb(NameTooLong). The same happens for a 12-byte symbol (0xc) and a 201-byte URI (0xd).Summary of Changes
TextEncoderbefore the checks (the encoded bytes were already used for the instruction data since js: Use UTF-8 byte length for metadata string prefixes #859) and compare the byte lengths against the limits. The error messages now say "bytes".updateTokenMetadatarejects a name, symbol and URI that are within the character count but over the byte limit.I used an AI assistant (Claude) while preparing this. I reproduced the issue and checked the fix and tests myself.
🤖 Generated with Claude Code