Clarify that onMount/onCleanup are reactive-tree based#1519
Open
singhvishalkr wants to merge 1 commit into
Open
Clarify that onMount/onCleanup are reactive-tree based#1519singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users sometimes expect onMount to fire when a component is literally inserted into the DOM, but it actually runs when the component is created within the reactive tree. This distinction matters when JSX is stored in a variable before being conditionally rendered.
I added a note to the onMount reference page explaining:
As Ryan confirmed on the issue, this is by design. The docs should reflect this clearly.
Closes #1167