driver: i2c: mv64xxx: cn9130 bus lockup issue - #615
Conversation
hishahbhavsar
commented
Aug 25, 2026
hishahbhavsar
commented
- This patch disable offload module, and disable the "i2c debug slave"
|
|
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
- This patch disable offload module, and disable the "i2c debug slave" Signed-off-by: Narendra Hadke <nhadke@marvell.com>
1c4d389 to
c09c2ed
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Refreshed patch 0023 against Linux v6.12.41 + patches through 0022. The original patch applied with fuzz, causing the CI patch application failure; the refreshed patch now applies cleanly. Could you please review the updated patch and approve PR #615 if everything looks good? Thank you. |
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Did you report this upstream? What do they say?
| @@ -0,0 +1,58 @@ | |||
| From 340e920894b0f3e7369905d0321221209b40ab30 Mon Sep 17 00:00:00 2001 | |||
| From: hshah <hshah@marvell.com> | |||
There was a problem hiding this comment.
Please use your full name.
| From 340e920894b0f3e7369905d0321221209b40ab30 Mon Sep 17 00:00:00 2001 | ||
| From: hshah <hshah@marvell.com> | ||
| Date: Thu, 27 Aug 2026 13:49:20 -0700 | ||
| Subject: [PATCH] driver: i2c: mv64xxx: cn9130 bus lockup issue |
There was a problem hiding this comment.
Please make it a statement by adding a verb in imperative mood.
| Date: Thu, 27 Aug 2026 13:49:20 -0700 | ||
| Subject: [PATCH] driver: i2c: mv64xxx: cn9130 bus lockup issue | ||
|
|
||
| This patch disable offload module, and disable the "i2c debug slave" |
There was a problem hiding this comment.
Please split into two patches, and add a problem description, and why your patch is the solution.
| + /* Disable I2C slave */ | ||
| + data = readl(drv_data->reg_base + drv_data->reg_offsets.config_debug); | ||
| + data &= ~BIT(18); | ||
| + writel(data, drv_data->reg_base + drv_data->reg_offsets.config_debug); |
There was a problem hiding this comment.
regmap_clear_bits(drv_data->map, drv_data->reg_offsets.config_debug, BIT(18));
|
@vmytnyk-plv, thank you for looking at this, but what did you review exactly? |
4 participants
