Skip to content

Add Delta Q54SN120A1 and Q54SW120A7 support - #617

Open
antonio-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:antonio.q54sj108a2_kernel_patches
Open

Add Delta Q54SN120A1 and Q54SW120A7 support #617
antonio-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:antonio.q54sj108a2_kernel_patches

Conversation

@antonio-nexthop

@antonio-nexthop antonio-nexthop commented Aug 27, 2026

Copy link
Copy Markdown

Add Delta Q54SN120A1 and Q54SW120A7 1/4-brick DC/DC power module support to the q54sj108a2 pmbus driver, from upstream: https://lore.kernel.org/all/20260316-add-q54sn120a1-q54q54sw120a7-v2-0-60e6182cc4a7@gmail.com/

Verification:

On NH-4220 platform running image with these kernel patches:

admin@abcd162:~$ cd /sys/bus/i2c/devices/83-0060/
admin@abcd162:/sys/bus/i2c/devices/83-0060$ ls
driver  hwmon  modalias  name  pec  power  subsystem  uevent
admin@abcd162:/sys/bus/i2c/devices/83-0060$ ls -l driver
lrwxrwxrwx 1 root root 0 Aug 22 00:09 driver -> ../../../../../../../../bus/i2c/drivers/q54sj108a2
admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat temp | grep IBV
                IBV_DCDC0         29          110.0       N/A           130.0            N/A      False  20260822 00:09:40
                IBV_DCDC1         29          110.0       N/A           130.0            N/A      False  20260822 00:09:40
                IBV_DCDC2         31          110.0       N/A           130.0            N/A      False  20260822 00:09:40
admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat volt | grep IBV
IBV_DCDC0_OUTPUT  12330.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
IBV_DCDC1_OUTPUT  12332.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
IBV_DCDC2_OUTPUT  12329.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat curr | grep IBV
IBV_DCDC0_OUTPUT   13500.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
IBV_DCDC1_OUTPUT   13000.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
IBV_DCDC2_OUTPUT   11000.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
admin@abcd162:/sys/bus/i2c/devices/83-0060$
root@abcd162:/sys/kernel/debug/pmbus/hwmon90# ls
mfr_date  mfr_location  mfr_revision  q54sj108a2  status0_cml    status0_iout  status0_temp
mfr_id    mfr_model     mfr_serial    status0     status0_input  status0_mfr   status0_vout
root@abcd162:/sys/kernel/debug/pmbus/hwmon90/q54sj108a2# ls -al
total 0
drwxr-xr-x 2 root root 0 Aug 22 00:08 .
drwxr-xr-x 3 root root 0 Aug 22 00:08 ..
--w------- 1 root root 0 Aug 22 00:08 blackbox_erase
-r--r--r-- 1 root root 0 Aug 22 00:08 blackbox_read
-r--r--r-- 1 root root 0 Aug 22 00:08 blackbox_read_offset
--w------- 1 root root 0 Aug 22 00:08 blackbox_set_offset
--w------- 1 root root 0 Aug 22 00:08 clear_fault
-r--r--r-- 1 root root 0 Aug 22 00:08 flash_key
-rw-r--r-- 1 root root 0 Aug 22 00:08 io_oc_response
-r--r--r-- 1 root root 0 Aug 22 00:08 mfr_id
-r--r--r-- 1 root root 0 Aug 22 00:08 mfr_location
-r--r--r-- 1 root root 0 Aug 22 00:08 mfr_model
-r--r--r-- 1 root root 0 Aug 22 00:08 mfr_revision
-rw-r--r-- 1 root root 0 Aug 22 00:08 operation
-r--r--r-- 1 root root 0 Aug 22 00:08 pmbus_revision
--w------- 1 root root 0 Aug 22 00:08 store_default
-rw-r--r-- 1 root root 0 Aug 22 00:08 vo_ov_response
-r--r--r-- 1 root root 0 Aug 22 00:08 write_protect
root@abcd162:/sys/kernel/debug/pmbus/hwmon90/q54sj108a2#

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@antonio-nexthop
antonio-nexthop marked this pull request as ready for review August 27, 2026 22:00
@antonio-nexthop
antonio-nexthop requested a review from a team as a code owner August 27, 2026 22:00
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

nh-grecs Bot pushed a commit to nexthop-ai/sonic-linux-kernel that referenced this pull request Aug 28, 2026
rebuild-source: sonic-net#617 @ nexthop-ai/sonic-linux-kernel 4b3d907 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-linux-kernel that referenced this pull request Aug 29, 2026
rebuild-source: sonic-net#617 @ nexthop-ai/sonic-linux-kernel 4b3d907 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-linux-kernel that referenced this pull request Aug 29, 2026
rebuild-source: sonic-net#617 @ nexthop-ai/sonic-linux-kernel 4b3d907 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-linux-kernel that referenced this pull request Aug 31, 2026
rebuild-source: sonic-net#617 @ nexthop-ai/sonic-linux-kernel 4b3d907 [case: upstream:open]
nh-grecs Bot pushed a commit to nexthop-ai/sonic-linux-kernel that referenced this pull request Aug 31, 2026
rebuild-source: sonic-net#617 @ nexthop-ai/sonic-linux-kernel 4b3d907 [case: upstream:open]
@antonio-nexthop

Copy link
Copy Markdown
Author

Hi @saiarcot895, can I please get a review on this PR? Thank you for your help!

@paulmenzel paulmenzel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if you could copy the merge/pull request description to the commit message, as, I believe, the merge request description does not end up in the git archive. Otherwise, it looks good. Thank you for backporting. You might want to ask upstream to backport the support.

Add Delta Q54SN120A1 and Q54SW120A7 1/4-brick DC/DC power module
support to the q54sj108a2 pmbus driver, from upstream:
https://lore.kernel.org/all/20260316-add-q54sn120a1-q54q54sw120a7-v2-0-60e6182cc4a7@gmail.com/

Enable CONFIG_SENSORS_Q54SJ108A2 for amd64.

Verification:

On NH-4220 platform running image with these kernel patches:

    admin@abcd162:~$ cd /sys/bus/i2c/devices/83-0060/
    admin@abcd162:/sys/bus/i2c/devices/83-0060$ ls
    driver  hwmon  modalias  name  pec  power  subsystem  uevent
    admin@abcd162:/sys/bus/i2c/devices/83-0060$ ls -l driver
    lrwxrwxrwx 1 root root 0 Aug 22 00:09 driver -> ../../../../../../../../bus/i2c/drivers/q54sj108a2
    admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat temp | grep IBV
                    IBV_DCDC0         29          110.0       N/A           130.0            N/A      False  20260822 00:09:40
                    IBV_DCDC1         29          110.0       N/A           130.0            N/A      False  20260822 00:09:40
                    IBV_DCDC2         31          110.0       N/A           130.0            N/A      False  20260822 00:09:40
    admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat volt | grep IBV
    IBV_DCDC0_OUTPUT  12330.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
    IBV_DCDC1_OUTPUT  12332.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
    IBV_DCDC2_OUTPUT  12329.0 mV    13500.0       N/A           14500            N/A      False  20260822 00:09:30
    admin@abcd162:/sys/bus/i2c/devices/83-0060$ show plat curr | grep IBV
    IBV_DCDC0_OUTPUT   13500.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
    IBV_DCDC1_OUTPUT   13000.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
    IBV_DCDC2_OUTPUT   11000.0 mA  190000              N/A  240000                    N/A      False  20260822 00:09:30
    admin@abcd162:/sys/bus/i2c/devices/83-0060$
    root@abcd162:/sys/kernel/debug/pmbus/hwmon90# ls
    mfr_date  mfr_location  mfr_revision  q54sj108a2  status0_cml    status0_iout  status0_temp
    mfr_id    mfr_model     mfr_serial    status0     status0_input  status0_mfr   status0_vout
    root@abcd162:/sys/kernel/debug/pmbus/hwmon90/q54sj108a2# ls -al
    total 0
    drwxr-xr-x 2 root root 0 Aug 22 00:08 .
    drwxr-xr-x 3 root root 0 Aug 22 00:08 ..
    --w------- 1 root root 0 Aug 22 00:08 blackbox_erase
    -r--r--r-- 1 root root 0 Aug 22 00:08 blackbox_read
    -r--r--r-- 1 root root 0 Aug 22 00:08 blackbox_read_offset
    --w------- 1 root root 0 Aug 22 00:08 blackbox_set_offset
    --w------- 1 root root 0 Aug 22 00:08 clear_fault
    -r--r--r-- 1 root root 0 Aug 22 00:08 flash_key
    -rw-r--r-- 1 root root 0 Aug 22 00:08 io_oc_response
    -r--r--r-- 1 root root 0 Aug 22 00:08 mfr_id
    -r--r--r-- 1 root root 0 Aug 22 00:08 mfr_location
    -r--r--r-- 1 root root 0 Aug 22 00:08 mfr_model
    -r--r--r-- 1 root root 0 Aug 22 00:08 mfr_revision
    -rw-r--r-- 1 root root 0 Aug 22 00:08 operation
    -r--r--r-- 1 root root 0 Aug 22 00:08 pmbus_revision
    --w------- 1 root root 0 Aug 22 00:08 store_default
    -rw-r--r-- 1 root root 0 Aug 22 00:08 vo_ov_response
    -r--r--r-- 1 root root 0 Aug 22 00:08 write_protect
    root@abcd162:/sys/kernel/debug/pmbus/hwmon90/q54sj108a2#

Signed-off-by: Antonio Hui <antonio@nexthop.ai>
@antonio-nexthop
antonio-nexthop force-pushed the antonio.q54sj108a2_kernel_patches branch from 4b3d907 to 275723c Compare August 31, 2026 22:33
@mssonicbld

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants