fix/perf: Do not prefetch the header Changelog link - #2002
Draft
marcleblanc2 wants to merge 1 commit into
Draft
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
The Changelog link in the desktop header and mobile navigation was a next/link, so every docs page prefetched the changelog route (about 61 requests and 500 KB per page view in the audit). Render it as a plain anchor, matching the external sidebar links. Found by the docs site audit in https://ampcode.com/threads/T-01a0ae50-f7f0-779c-aa66-3887c9953e33 Amp-Thread-ID: https://ampcode.com/threads/T-01a0aed2-5fbe-7768-85ea-1378bf98f9ff Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Changelog link in the desktop header (
src/components/Layout.tsx) and mobile navigation (src/components/MobileNavigation.tsx) is anext/linktohttps://sourcegraph.com/changelog. Because it is same-origin in production, Next treats it as an app route and prefetches the changelog app: the audit measured about 61 extra requests / ~500 KB on every docs page view.Fix
Render both as plain
<a>, the same approach #1978 takes for external sidebar links.prefetch={false}would also work; a plain anchor is simpler for a link that leaves the app.Verification
npx tsc --noEmitandpnpm run lintclean (0 errors). On a preview, the Network tab should show no/changelogchunk requests after load.Found by the docs site audit in this Amp thread; rebuilt locally in this one.