zoekt-index: reject colliding positional paths - #1165
Merged
Merged
Conversation
Multiple positional paths can resolve to the same shard prefix, causing each completed build to remove the shards created for the preceding path. Rejecting the collision before indexing avoids silent data loss without inventing ambiguous multi-root repository semantics. Amp-Thread-ID: https://ampcode.com/threads/T-01a07aa9-098b-7057-ae06-d1581bc5de5b Co-authored-by: Amp <amp@ampcode.com>
burmudar
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple positional paths can resolve to the same shard prefix, causing a later build to silently delete the shards created for an earlier path. This change detects those collisions and fails before writing any indexes.
Unlike the proposed fix in the issue, this does not implicitly combine directories into one repository. Multiple roots have ambiguous filename, source, and branch semantics, so a shared shard prefix is treated as invalid configuration instead.
Fixes #1133