fix: sync listing address autocomplete with map pin - #3032
Open
RabbiIslamRony wants to merge 2 commits into
Open
RabbiIslamRony wants to merge 2 commits into
RabbiIslamRony wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
The Google address autocomplete could be initialized more than once. After selecting a suggestion, the address field could change while the map retained its previous marker. The address field also stopped loading Google Places suggestions when the map field was removed from the listing form.
This PR:
AdvancedMarkerElement.map = nullAPI when removing markers.How to reproduce / test
Before and after
The before image is the client-provided failure case. The after image is an isolated browser replay on the same form using the fixed bundle; no client-site files or settings were changed.
Verification
npm run build-legacyphp -l includes/asset-loader/init.phpgit diff --checkAny linked issues
TeamSync: #3332 — Location field updates, map pin fails
Checklist